Menu ▾ ▴

#85 umasked XML characters

closed
Bernhard Wymann
None
1
2012-07-03
2007-02-03
Carsten Milkau
No

Using one of the keys "<" ">" or "&" as control keys causes torcs to crash when trying to load the perferences. Reason is, those characters are not masked when written to the preferences file, thus it's no longer valid XML. Apparantly, torcs is intolerant towards parser errors and crashes. Possible fix: check for parser errors and exit cleanly with a helpful error message (helpful for you bug wranglers); check for XML special characters (there are only these three) and mask them by < > and &, respectively. These three entities are always valid in XML documents and need not be declared using <!ENTITY> (in fact, they can't).

With Regards
Carsten

Discussion

  • Bernhard Wymann

    Bernhard Wymann - 2007-11-01

    Logged In: YES
    user_id=318462
    Originator: NO

    Fixed in CVS, thank you for the report. Beware, the suggested fix from Debian is not correct at all (e.g. change the player name to ">Player", enjoy).

     

  • Bernhard Wymann

    Bernhard Wymann - 2008-09-04

    Logged In: YES
    user_id=318462
    Originator: NO

    fixed in 1.3.1-test1