Work at SourceForge, help us to make it a better place! We have an immediate need for a Support Technician in our San Francisco or Denver office.

Close

#2501 Mirrored text if Xft is used

obsolete: 8.6a4
closed-fixed
5
2008-12-22
2008-09-12
Sergei Golovan
No

Hi!

Appears that if Xft-enabled fonts are used and font size is negative (gives size in pixels, not in points) then canvas postscript prints text inverted (rotated at 180 degrees).

The problem is that Tk_PostscriptFontName() is expected to return font size in points, but it returns just TkFont size attribute which may be negative.

The attached patch converts negative size attribute to positive, so canvas postscript becomes working again.

Discussion

1 2 > >> (Page 1 of 2)
  • Sergei Golovan
    Sergei Golovan
    2008-09-12

    Makes font size always positive (in points, not in pixels)

     
    Attachments
    • assigned_to: hobbs --> dkf
    • milestone: --> obsolete: 8.6a4
    • status: open --> closed-fixed
     
  • Fixed now.

    Also got rid of the stupidity which had us distributing a PS prolog which wasn't used, and made rotated text print properly (well, assuming it gets mapped to a font that the printer understands correctly, which is a whole separate issue.)

     
  • Don Porter
    Don Porter
    2008-12-21

    backport for 8.5.6 ?

     
  • Don Porter
    Don Porter
    2008-12-21

    • status: closed-fixed --> open-fixed
     
  • Done (well, the part that was the fix of this bug...)

     
    • status: open-fixed --> closed-fixed
     
  • Don Porter
    Don Porter
    2008-12-22

    thanks for the effort, but
    the build is now broken:

    /local/home/dgp/cvs/tk8.5/unix/../generic/tkCanvPs.c: In function ‘Tk_PostscriptFont’:
    /local/home/dgp/cvs/tk8.5/unix/../generic/tkCanvPs.c:758: warning: implicit declaration of function ‘TkFontGetPoints’
    /local/home/dgp/cvs/tk8.5/unix/../generic/tkCanvPs.c:758: error: ‘TkPostscriptInfo’ has no member named ‘tkwin’

    Please fix or revert.

     
  • Don Porter
    Don Porter
    2008-12-22

    • status: closed-fixed --> open-fixed
     
  • Bother, I'd forgotten that I'd added the 'tkwin' field.

    Now builds right.

     
1 2 > >> (Page 1 of 2)