Menu

#22 timer-applet Python code contains several syntax errors

open
nobody
None
5
2009-10-08
2009-10-08
No

Given that I just ran into this bug a few moment ago:
https://sourceforge.net/tracker/?func=detail&aid=2874996&group_id=127778&atid=709446

... I was thinking that you probably just wrote this Python code without running it through a static analysis tool.
Since Python doesn't do static type checking, it's easy to ship buggy code; code that can never run correctly.

It would be neat if you took some time to run pylint, pyflakes and pychecker on timer-applet. This will most certainly find some real bugs!
For example, these are all the syntax _errors_ (not warnings but hard errors) that pylint finds in timer-applet.

(PS. Thanks for a great applet, I use it every day!)

mnemo@kingfish:/usr/lib/python2.6/dist-packages/timerapplet$ find . -name \*.py | xargs pylint -e
No config file found, using default configuration
************* Module controllers.TimerManagerService
E: 30:TimerManagerService.create_and_register_timer_id: Undefined variable 'uuid'
Exception RuntimeError: 'maximum recursion depth exceeded while calling a Python object' in <type 'exceptions.RuntimeError'> ignored
Exception RuntimeError: 'maximum recursion depth exceeded while calling a Python object' in <type 'exceptions.AttributeError'> ignored
Exception RuntimeError: 'maximum recursion depth exceeded while calling a Python object' in <type 'exceptions.AttributeError'> ignored
Exception RuntimeError: 'maximum recursion depth exceeded while calling a Python object' in <type 'exceptions.AttributeError'> ignored
Exception RuntimeError: 'maximum recursion depth exceeded while calling a Python object' in <type 'exceptions.AttributeError'> ignored
Exception RuntimeError: 'maximum recursion depth exceeded while calling a Python object' in <type 'exceptions.AttributeError'> ignored
Exception RuntimeError: 'maximum recursion depth exceeded while calling a Python object' in <type 'exceptions.AttributeError'> ignored
Exception RuntimeError: 'maximum recursion depth exceeded while calling a Python object' in <type 'exceptions.AttributeError'> ignored
Exception RuntimeError: 'maximum recursion depth exceeded while calling a Python object' in <type 'exceptions.AttributeError'> ignored
************* Module ui.ScrollableButtonList
E: 36:ScrollableButtonList.__init__: Class 'style' has no 'base' member
************* Module timerapplet.ui.PulseButton
E: 49:PulseButton._on_timeout: Class 'window' has no 'invalidate_rect' member
E: 56:PulseButton.do_expose_event: Class 'allocation' has no 'width' member
E: 56:PulseButton.do_expose_event: Class 'allocation' has no 'height' member
************* Module timerapplet.ui.ContinueTimerDialog
E: 33:ContinueTimerDialog.__init__: Class 'vbox' has no 'props' member
E: 50:ContinueTimerDialog.__init__: Class 'vbox' has no 'pack_start' member
************* Module timerapplet.ui.PieMeter
E: 34:PieMeter.set_progress: Class 'window' has no 'invalidate_rect' member
E: 43:PieMeter.set_fill_color: Class 'window' has no 'invalidate_rect' member
E: 53:PieMeter.do_expose_event: Class 'allocation' has no 'x' member
E: 53:PieMeter.do_expose_event: Class 'allocation' has no 'width' member
E: 54:PieMeter.do_expose_event: Class 'allocation' has no 'y' member
E: 54:PieMeter.do_expose_event: Class 'allocation' has no 'height' member
E: 55:PieMeter.do_expose_event: Class 'allocation' has no 'width' member
E: 55:PieMeter.do_expose_event: Class 'allocation' has no 'height' member

Discussion


Log in to post a comment.