Menu

#31 Better inter-wiki links and forced links

open
nobody
None
5
2012-12-08
2003-05-07
No

This patch (made against 1.6 from CVS, tag
release_tauceti) make the following changes:

- Allows slashes in the text inside double parenthesis
((...)). This is to allow interwiki links to have
slashed in their parenthesis, to allow for example:
((MYSITE:/some/page)). I'm not sure if allowing slashed
in the regular expression (it was added to $page_regex)
will break anything else, but so far it seems to work OK.

- In the processing of things inside double
parenthesis, replaced most of the calls to preg_replace
with str_replace, since what is being replaced is a
fixed test and not a regular expression. Using
preg_replace made it necessary to escape special
characters like parenthesis, slashes, etc., which is
unnecessary now.

Discussion

  • Diego Zamboni

    Diego Zamboni - 2003-05-26

    Patch to allow slashes in $page_regex.

     
  • Diego Zamboni

    Diego Zamboni - 2003-05-26

    Logged In: YES
    user_id=5875

    Update: I split the patch in two:

    tiki-allow-slashes.patch simply adds the slash to the list
    of allowed characters in $page_regex.

    tiki-fixextlinks.patch fixes the text replacement of links
    to external wikis (it was broken both because of the use of
    preg_replace and there was a bug in handling the case with a
    vertical bar to indicate the text to put in the link).

     
  • Diego Zamboni

    Diego Zamboni - 2003-05-27

    Logged In: YES
    user_id=5875

    tiki-fixextlinks.patch had a bug that prevented ordinary
    links with descriptions from working properly. Fixed now.

     
  • Diego Zamboni

    Diego Zamboni - 2003-05-27

    Fix replacement of links to external wikis.

     
  • alan johnson

    alan johnson - 2004-05-01

    Logged In: YES
    user_id=943591

    this should fix it proper

     

Log in to post a comment.