Menu
▾
▴
#4730 Patch: Do not output CC#7 events in MIDI on dynamic changes
Following up on my own comment in https://lists.gnu.org/archive/html/lilypond-user/2015-10/msg00098.html,
I've observed that LilyPond actually emits CC#7 events to a generated
MIDI file on dynamic (MIDI velocity) changes created by the
Dynamic_performer, but these CC#7 changes seem to always just set the
MIDI volume to 100 (in the range from 0 to 127). To me this looks like
a possible bug (and could be just a remnant of the implementation prior
to 2.14), but this is only my personal opinion...
I've tried to fix this defect to make the handling of MIDI CC#7 more consistent with how the other MIDI channel controls are handled (that is, avoid enforcing any "default" values on any controls).
(This is in preparation for a larger patch to follow for making all MIDI controls adjustable from within LilyPond code using context properties; for that change, it's best to first reduce any unnecessary automatic adjustment of the MIDI channel controls.)
The patch is available for review (with further technical information) at
https://codereview.appspot.com/277700043/.
passes make, make check and a full make doc
Patch on countdown for January 15th.
Patch counted down - please push.
As I don't have push rights, I'm attaching the patch here.
Thanks Heikki
author Heikki Tauriainen g034737@welho.com
Thu, 7 Jan 2016 08:05:27 +0000 (10:05 +0200)
committer James Lowe pkx166h@gmail.com
Fri, 15 Jan 2016 19:51:33 +0000 (19:51 +0000)
commit c27954a2ec2c13e14666408982e156bea20e806a