Menu

#4722 Introduce new markup-command draw-squiggle-line.

Verified
Enhancement
2016-03-02
2016-01-05
No

Introduce new markup-command draw-squiggle-line.

Change regtest /input/regression/markup-line-styles.ly accordingly

http://codereview.appspot.com/281210043

Discussion

  • Anonymous

    Anonymous - 2016-01-05

    Fails make (and would fail make doc too) - see rietveld.

     

    Last edit: Anonymous 2016-01-05
  • Anonymous

    Anonymous - 2016-01-05
    • Description has changed:

    Diff:

    
    
    • Needs: -->
    • Patch: new --> needs_work
     
  • Thomas Morley

    Thomas Morley - 2016-01-05

    corrects typo in doc-string

    http://codereview.appspot.com/281210043

     
  • Thomas Morley

    Thomas Morley - 2016-01-06

    found some fishy code in it, hence setting it to needs-work

     
  • Thomas Morley

    Thomas Morley - 2016-01-06
    • Needs: -->
    • Patch: new --> needs_work
    • Type: -->
     
  • Thomas Morley

    Thomas Morley - 2016-01-06

    improve coding, better regtest

    http://codereview.appspot.com/281210043

     
  • Anonymous

    Anonymous - 2016-01-06
    • Needs: -->
    • Patch: new --> review
    • Type: --> Enhancement
     
  • Anonymous

    Anonymous - 2016-01-06

    Passes make, make check and a full make doc

     
  • Simon Albrecht

    Simon Albrecht - 2016-01-06

    Thanks, mate! This is huge fun ;-)

    \markup {
      \box
      \general-align #Y #1
      \override #'(height . 2)
      \override #'(angularity . -10)
      \override #'(orientation . 0.96)
      \draw-squiggle-line #'0.5 #'(10 . 0) ##f
    }
    
     
    • Thomas Morley

      Thomas Morley - 2016-01-06

      Glad you like it.
      And thanks you played around with it! Using your code I could observe a bug:
      An override of orientation should not affect thickness, that's ofcourse the duty of a thickness-override.
      A quick test resulted in no problem with draw-squiggled-line but with the underlying make-bow-stencil.
      Will investigate further.

       
  • Thomas Morley

    Thomas Morley - 2016-01-07

    corrects doc-string, adds entry in changes

    http://codereview.appspot.com/281210043

     
  • Anonymous

    Anonymous - 2016-01-08
    • Needs: -->
    • Patch: new --> review
    • Type: --> Enhancement
     
  • Anonymous

    Anonymous - 2016-01-08

    Passes make, make check and a full make doc.

     
  • Anonymous

    Anonymous - 2016-01-09
    • Patch: review --> countdown
     
  • Anonymous

    Anonymous - 2016-01-09

    Patch on countdown for Jan 12th

     
  • Thomas Morley

    Thomas Morley - 2016-01-11
    • Patch: countdown --> review
     
  • Thomas Morley

    Thomas Morley - 2016-01-11

    I've put it back on review. I'd like to hear more thoughts about the user-interface.

     
  • Anonymous

    Anonymous - 2016-01-15
    • Patch: review --> countdown
     
  • Anonymous

    Anonymous - 2016-01-15

    Patch on countdown for Jan 18th.

     
  • Anonymous

    Anonymous - 2016-01-18
    • Patch: countdown --> push
     
  • Anonymous

    Anonymous - 2016-01-18

    Patch counted down - please push.

     
  • Thomas Morley

    Thomas Morley - 2016-01-19
    • labels: --> Fixed_2_19_36
    • status: Started --> Fixed
    • Patch: push -->
     
  • Thomas Morley

    Thomas Morley - 2016-01-19

    I would have loved more opinions about it. Though, it's now second time on count-down, thus:
    pushed to staging as

    commit e426ea7b5af83739ab2f3a255e8cbac55b16e6ec
    Author: Thomas Morley thomasmorley65@gmail.com
    Date: Tue Jan 5 16:18:53 2016 +0100

    Issue 4722 Introduce new markup-command draw-squiggle-line.
    
    Change regtest /input/regression/markup-line-styles.ly accordingly
    
     
  • Simon Albrecht

    Simon Albrecht - 2016-03-02
    • status: Fixed --> Verified