Glad you like it.
And thanks you played around with it! Using your code I could observe a bug:
An override of orientation should not affect thickness, that's ofcourse the duty of a thickness-override.
A quick test resulted in no problem with draw-squiggled-line but with the underlying make-bow-stencil.
Will investigate further.
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Fails make (and would fail make doc too) - see rietveld.
Last edit: Anonymous 2016-01-05
Diff:
corrects typo in doc-string
http://codereview.appspot.com/281210043
found some fishy code in it, hence setting it to needs-work
improve coding, better regtest
http://codereview.appspot.com/281210043
Passes make, make check and a full make doc
Thanks, mate! This is huge fun ;-)
Glad you like it.
And thanks you played around with it! Using your code I could observe a bug:
An override of orientation should not affect thickness, that's ofcourse the duty of a thickness-override.
A quick test resulted in no problem with draw-squiggled-line but with the underlying make-bow-stencil.
Will investigate further.
This is now issue 4725
https://sourceforge.net/p/testlilyissues/issues/4725/
with patch.
corrects doc-string, adds entry in changes
http://codereview.appspot.com/281210043
Passes make, make check and a full make doc.
Patch on countdown for Jan 12th
I've put it back on review. I'd like to hear more thoughts about the user-interface.
Patch on countdown for Jan 18th.
Patch counted down - please push.
I would have loved more opinions about it. Though, it's now second time on count-down, thus:
pushed to staging as
commit e426ea7b5af83739ab2f3a255e8cbac55b16e6ec
Author: Thomas Morley thomasmorley65@gmail.com
Date: Tue Jan 5 16:18:53 2016 +0100