#4716 Improve note-by-number to deal better with flag-styles

[Thomas Morley]

Improve note-by-number to deal better with flag-styles

• Per default every ancient note-head will get a mensural-style-flag.
• overriding flag-style will now always work with supported styles:
  default, straight- and flat-flags and (neo-)mensural-flags

http://codereview.appspot.com/284000043

[Thomas Morley]

corrects version in regtest

http://codereview.appspot.com/284000043

[Thomas Morley]

Simon's comment

http://codereview.appspot.com/284000043

[Anonymous]

Passes make, make check and a full make doc.

[Thomas Morley]

Werners comment

http://codereview.appspot.com/284000043

[Thomas Morley]

I extended the regtest, the changes in note-by-number should change the output of the regtest as well.
Why does it not pop up after patchy-testing?

[Anonymous]

Passes make, make check and a full make doc.

I don't use Patchy BTW - it doesn't work with Allura I simply use the good old fashinoned, manual method. However I cannot tell you why make test-baseline followed by a make, make check doesn't give me any reg test diffs.

[David Kastrup]

However I cannot tell you why make test-baseline followed by a make, make check doesn't give me any reg test diffs.

Uh, that would make both comparison targets the same. Why should there be a reg test diff?

You first do make clean && ./configure --enable-checking && make && make test-baseline with a checkout of current master. Then you apply the patch using git apply --index, do a make clean, redo ./configure --enable-checking && make and only then do make check.

And that will give you the change as compared to master in out/test-results/index.html. But as long as you do make check in the same version as you ran make test-baseline in, any difference is the consequence of non-deterministic behavior for the same input.

[Anonymous]

OK I was trying to be brief.

My workflow includes a make clean and the apply of the patch in between the make/make check and the make/make test-baseline.

I basically follow the commands that the Patchy Script uses.

Although you said '... ./configure --enable-checking ..' whereas I have always done '..../configure --disable-optimising' (as per patchy).

[Anonymous]

Patch on countdown for Jan 3rd.

[Anonymous]

Patch counted down - please push.

[Thomas Morley]

pushed to staging as

commit 7515e9c36a25c513f94c19a7b3d15ff17ba68a84
Author: Thomas Morley thomasmorley65@gmail.com
Date: Sun Dec 27 22:33:12 2015 +0100

Issue 4716 Improve note-by-number to deal better with flag-styles

- Per default every ancient note-head will get a mensural-style-flag.
- overriding flag-style will now always work with supported styles:
  default, straight- and flat-flags and (neo-)mensural-flags