Menu

#4682 Add and use note-collision-threshold grob property

Verified
2016-01-03
2015-12-04
Paul Morris
No

Add and use note-collision-threshold grob property

Includes a regression test.

http://codereview.appspot.com/271680043

Discussion

  • Paul Morris

    Paul Morris - 2015-12-04

    small improvement in stem.cc

    http://codereview.appspot.com/271680043

     
  • Paul Morris

    Paul Morris - 2015-12-04

    When StaffSymbol.staff-space is overridden to a value less than 1, collisions
    can occur between simultaneous notes that are more than one staff space apart.

    This patch introduces a property "note-collision-threshold" that makes it
    possible to prevent this. By setting this property to 2 or more, LilyPond will
    identify notes 2 or more staff positions apart as collisions and move the notes
    accordingly to prevent them.

    Basically, this patch un-hard-codes the assumption that collisions only occur
    when simultaneous notes are 1 staff space apart and allows the user to override
    this threshold with a different value when that is needed.

    See regtest for an example of use.

     
  • Anonymous

    Anonymous - 2015-12-05

    Passes make, make check and a full make doc.

     
  • Anonymous

    Anonymous - 2015-12-05
    • Description has changed:

    Diff:

    
    
    • Needs: -->
    • Patch: new --> review
    • Type: -->
     
  • Anonymous

    Anonymous - 2015-12-07
    • Patch: review --> countdown
     
  • Anonymous

    Anonymous - 2015-12-07

    Patch on countdown for December the 10th.

     
  • Anonymous

    Anonymous - 2015-12-10
    • Patch: countdown --> push
     
  • Anonymous

    Anonymous - 2015-12-10

    Patch counted down - please push.

     
  • Anonymous

    Anonymous - 2015-12-11
    • labels: --> Fixed_2_19_34
    • status: Started --> Fixed
    • Patch: push -->
     
  • Anonymous

    Anonymous - 2015-12-11

    author Paul Morris paulwmorris@gmail.com
    Thu, 26 Nov 2015 01:58:01 +0000 (20:58 -0500)
    committer James Lowe pkx166h@gmail.com
    Fri, 11 Dec 2015 15:46:57 +0000 (15:46 +0000)
    commit 74bd453cc3da31d047b2611aad5669395fc71447

     
  • Simon Albrecht

    Simon Albrecht - 2016-01-03
    • status: Fixed --> Verified
    • assigned_to: Paul Morris --> nobody
     
  • Simon Albrecht

    Simon Albrecht - 2016-01-03
    • assigned_to: Paul Morris