Menu ▾ ▴

#5 extension_data not set, may cause host crash

open
nobody
None
5
2011-10-20
2011-10-20
falkTX
No

In compressor-sc4 and multiband-filter, the lv2 descriptors do not have extension_data set to NULL, possibly making a host crash
(the pointer is not NULL/0, so host thinks it's valid.)

Discussion

  • falkTX

    falkTX - 2011-10-20

    1st patch

     
    compressor_sc4.patch

  • falkTX

    falkTX - 2011-10-20

    (it seems sourceforge doesn't allow 2 attached files??, so I post here the 2nd patch)

    --- dynamicmultiband.c.orig 2010-04-25 16:25:06.000000000 +0100
    +++ dynamicmultiband.c 2011-10-20 22:37:39.371505648 +0100
    @@ -1015,6 +1015,7 @@
    db5Descriptorm->deactivate = NULL;
    db5Descriptorm->instantiate = instantiate_db5;
    db5Descriptorm->run = run_db5m;
    + db5Descriptorm->extension_data = NULL;

    db5Descriptor = (LV2_Descriptor *)malloc(sizeof(LV2_Descriptor));

    @@ -1025,6 +1026,7 @@
    db5Descriptor->deactivate = NULL;
    db5Descriptor->instantiate = instantiate_db5;
    db5Descriptor->run = run_db5;
    + db5Descriptor->extension_data = NULL;

    }

     

Log in to post a comment.