Menu ▾ ▴

#5036 --disable-threads build broken

obsolete: 8.6b2
closed-fixed
Andreas Kupries
27. Channel Types (246)
9
2012-05-22
2012-05-21
Don Porter
No

Starting with checkin 32d93a8414 a --disable-threads build fails:

/Users/dgp/fossil/tcl-only/generic/tclIORChan.c: In function ‘TclChanPostEventObjCmd’:
/Users/dgp/fossil/tcl-only/generic/tclIORChan.c:954: warning: implicit declaration of function ‘GetThreadReflectedChannelMap’
/Users/dgp/fossil/tcl-only/generic/tclIORChan.c:956: error: ‘ReflectedChannel’ has no member named ‘owner’
/Users/dgp/fossil/tcl-only/generic/tclIORChan.c:956: error: ‘ReflectedChannel’ has no member named ‘thread’
/Users/dgp/fossil/tcl-only/generic/tclIORChan.c:965: error: ‘ReflectedChannel’ has no member named ‘owner’
/Users/dgp/fossil/tcl-only/generic/tclIORChan.c:966: error: ‘ReflectedChannel’ has no member named ‘owner’
make: *** [tclIORChan.o] Error 1

Discussion

  • Andreas Kupries

    Andreas Kupries - 2012-05-22

    Patch for possible fix, to test.

     
    iorchan.patch

  • Andreas Kupries

    Andreas Kupries - 2012-05-22

    Don, attached is a possible fix for the issue, protecting the thread specific parts of ChanPostEventObjCmd() against use when building without threads.

     

  • Don Porter

    Don Porter - 2012-05-22
    • status: open --> closed-fixed
     

  • Don Porter

    Don Porter - 2012-05-22

    patched tested and committed.

     

  • Andreas Kupries

    Andreas Kupries - 2012-05-22

    Thank you.