Menu

#3151 compile warnings: redeclaration of static functions

obsolete: 8.4.10
closed-fixed
5
2005-10-05
2005-06-03
No

Building Tcl 8.4.10 RC1 on HP-UX using the native
compiler, I get minor compile warnings in tclDate.c,
tclEncoding.c, and tclIOUtil.c. In all three cases,
static functions should be uniformly declared static.
I suggest these changes:

--- tclDate.c.orig 2005-03-15 11:53:35.000000000 -0600
+++ tclDate.c 2005-06-03 08:02:30.569926000 -0500
@@ -158,7 +158,7 @@
#endif
#endif
#ifndef TclDatelex
- int TclDatelex(void);
+ static int TclDatelex(void);
#endif
int TclDateparse(void);
#if defined(__cplusplus) && defined(__EXTERN_C__)

--- tclEncoding.c.orig 2005-06-02 17:13:59.000000000 -0500
+++ tclEncoding.c 2005-06-03 08:03:37.808642000 -0500
@@ -2970,7 +2970,7 @@

*-------------------------------------------------------------------------
*/

-int
+static int
TclFindEncodings(argv0)
CONST char *argv0; /* Name of executable
from argv[0] to main()
* in native multi-byte
encoding. */

--- tclIOUtil.c.orig 2005-05-24 12:48:46.000000000 -0500
+++ tclIOUtil.c 2005-06-03 08:04:29.830093000 -0500
@@ -1319,7 +1319,7 @@
*

*---------------------------------------------------------------------------
*/
-Tcl_Obj*
+static Tcl_Obj*
TclFSNormalizeAbsolutePath(interp, pathPtr, clientDataPtr)
Tcl_Interp* interp; /* Interpreter to use */
Tcl_Obj *pathPtr; /* Absolute path to
normalize */

Discussion

  • Bob Techentin

    Bob Techentin - 2005-06-03
    • assigned_to: mdejong --> hobbs
     
  • Jeffrey Hobbs

    Jeffrey Hobbs - 2005-10-05

    Logged In: YES
    user_id=72656

    tclDate.c is auto-generated, but I fixed the other refs.

     
  • Jeffrey Hobbs

    Jeffrey Hobbs - 2005-10-05
    • status: open --> closed-fixed