#2058 xcopy with /y switch not portable

[Anonymous]

Both the makefile.vc for Tcl and Tk contain calls to
the xcopy command that use the "/y" switch. This
switch is not supported on all versions of Windows,
in this case Windows NT 4.0.

[David Gravereaux]

Logged In: YES
user_id=7549

What's the correct switch to use for copy with overwrite? I
don't have NT 4 to test on.

[Nobody/Anonymous]

Logged In: NO

You should be able to use the following construct on
Windows NT and Windows 2000 (I just tested it):

echo y | xcopy (source) (dest)

JJM

[David Gravereaux]

Logged In: YES
user_id=7549

how about this change to makefile.vc?

#---------------------------------------------------------------------
# Installation.
#---------------------------------------------------------------------

!if "$(OS)" == "Windows_NT"
!if ![ver | find "4.0" > nul]
CPY = echo y | xcopy /i
!else
CPY = xcopy /i /y
!endif
!else
CPY = xcopy /i
!endif

install-binaries:
@echo installing $(TCLLIBNAME)
!if "$(TCLLIB)" != "$(TCLIMPLIB)"
@$(CPY) "$(TCLLIB)" "$(BIN_INSTALL_DIR)\"
..etc..

[David Gravereaux]

Logged In: YES
user_id=7549

committed to HEAD without success report, so I may be
causing an error. I need the verification that the patch is
working.