From: SourceForge.net <no...@so...> - 2008-04-19 06:09:07
|
Patches item #1943417, was opened at 2008-04-15 22:24 Message generated for change (Comment added) made by olly You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=301645&aid=1943417&group_id=1645 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. >Category: None Group: None Status: Open Resolution: None Priority: 5 Private: No Submitted By: Mark Klein (mklein1) >Assigned to: Olly Betts (olly) >Summary: [php] std_vector.i has a collision for reserved word "empty" Initial Comment: Index: Lib/php4/std_vector.i =================================================================== --- Lib/php4/std_vector.i (revision 10375) +++ Lib/php4/std_vector.i (working copy) @@ -48,6 +48,7 @@ public: vector(unsigned int size = 0); unsigned int size() const; + %rename(is_empty) empty; bool empty() const; void clear(); %rename(push) push_back; @@ -86,6 +87,7 @@ public: vector(unsigned int size = 0); unsigned int size() const; + %rename(is_empty) empty; bool empty() const; void clear(); %rename(push) push_back; linus:~/Documents/NAR/swig mklein$ ---------------------------------------------------------------------- >Comment By: Olly Betts (olly) Date: 2008-04-19 07:09 Message: Logged In: YES user_id=14972 Originator: NO Looks good to me. Presumably any other "empty()" methods need renaming similarly too. My only slight reservation is that I think this works OK as it is for PHP4, so this would be needlessly changing behaviour there. But it's about time to give up on PHP4 anyway, so I'll try to get this sorted out before the next release. ---------------------------------------------------------------------- Comment By: Mark Klein (mklein1) Date: 2008-04-15 22:25 Message: Logged In: YES user_id=2054784 Originator: YES Vector::empty when wrapped for PHP causes a conflict with PHP's reserved word "empty". The above patch works around this for me. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=301645&aid=1943417&group_id=1645 |
From: SourceForge.net <no...@so...> - 2008-07-04 01:24:50
|
Patches item #1943417, was opened at 2008-04-15 22:24 Message generated for change (Comment added) made by olly You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=301645&aid=1943417&group_id=1645 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: None >Status: Closed >Resolution: Accepted Priority: 5 Private: No Submitted By: Mark Klein (mklein1) Assigned to: Olly Betts (olly) Summary: [php] std_vector.i has a collision for reserved word "empty" Initial Comment: Index: Lib/php4/std_vector.i =================================================================== --- Lib/php4/std_vector.i (revision 10375) +++ Lib/php4/std_vector.i (working copy) @@ -48,6 +48,7 @@ public: vector(unsigned int size = 0); unsigned int size() const; + %rename(is_empty) empty; bool empty() const; void clear(); %rename(push) push_back; @@ -86,6 +87,7 @@ public: vector(unsigned int size = 0); unsigned int size() const; + %rename(is_empty) empty; bool empty() const; void clear(); %rename(push) push_back; linus:~/Documents/NAR/swig mklein$ ---------------------------------------------------------------------- >Comment By: Olly Betts (olly) Date: 2008-07-04 02:24 Message: Logged In: YES user_id=14972 Originator: NO Committed (along with similar change to std_map.i) as SVN rev 10650. Sorry it took a while to get to. BTW, if you supply patches in future, it would be more helpful to attach them rather than pasting them into a comment, as the latter messes up the formatting so they can't be automatically applied. Not a big problem in this case, but for a more complex patch it would be annoying. ---------------------------------------------------------------------- Comment By: Olly Betts (olly) Date: 2008-04-19 07:09 Message: Logged In: YES user_id=14972 Originator: NO Looks good to me. Presumably any other "empty()" methods need renaming similarly too. My only slight reservation is that I think this works OK as it is for PHP4, so this would be needlessly changing behaviour there. But it's about time to give up on PHP4 anyway, so I'll try to get this sorted out before the next release. ---------------------------------------------------------------------- Comment By: Mark Klein (mklein1) Date: 2008-04-15 22:25 Message: Logged In: YES user_id=2054784 Originator: YES Vector::empty when wrapped for PHP causes a conflict with PHP's reserved word "empty". The above patch works around this for me. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=301645&aid=1943417&group_id=1645 |