From: SourceForge.net <no...@so...> - 2007-11-25 21:32:11
|
Patches item #1838248, was opened at 2007-11-25 21:32 Message generated for change (Tracker Item Submitted) made by Item Submitter You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=301645&aid=1838248&group_id=1645 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: None Status: Open Resolution: None Priority: 5 Private: No Submitted By: Monty Taylor (sdirector) Assigned to: Nobody/Anonymous (nobody) Summary: Use automake srcdir/builddir locations Initial Comment: In Source/Makefile.am, there are two references to ../swig which become more robust if ../ is replaced with ${top_builddir} (specifically this breaks the way I'm personally using swig right now, of course) The patch should not affect anyone who is not trying to do anything crazy. Patch is against SVN:10172 ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=301645&aid=1838248&group_id=1645 |
From: SourceForge.net <no...@so...> - 2007-12-03 22:54:22
|
Patches item #1838248, was opened at 2007-11-25 21:32 Message generated for change (Comment added) made by wsfulton You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=301645&aid=1838248&group_id=1645 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: None Status: Open Resolution: None Priority: 5 Private: No Submitted By: Monty Taylor (sdirector) Assigned to: Nobody/Anonymous (nobody) Summary: Use automake srcdir/builddir locations Initial Comment: In Source/Makefile.am, there are two references to ../swig which become more robust if ../ is replaced with ${top_builddir} (specifically this breaks the way I'm personally using swig right now, of course) The patch should not affect anyone who is not trying to do anything crazy. Patch is against SVN:10172 ---------------------------------------------------------------------- >Comment By: William Fulton (wsfulton) Date: 2007-12-03 22:54 Message: Logged In: YES user_id=242951 Originator: NO The last patch posted to swig-user contains the following. Please explain how this patch improves on things as by my reckoning, it does nothing!... +0000 ======================================= === modified file 'swig/SWIG/Source/Makefile.am' --- swig/SWIG/Source/Makefile.am 2007-11-04 21:32:20 +0000 +++ swig/SWIG/Source/Makefile.am 2007-11-26 02:02:21 +0000 @@ -98,1 +98,1 @@ 98#·The·executable·is·copied·to·the·root·directory·for·installation·and ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=301645&aid=1838248&group_id=1645 |
From: SourceForge.net <no...@so...> - 2007-12-04 19:12:01
|
Patches item #1838248, was opened at 2007-11-25 21:32 Message generated for change (Comment added) made by sdirector You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=301645&aid=1838248&group_id=1645 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: None Status: Open Resolution: None Priority: 5 Private: No Submitted By: Monty Taylor (sdirector) Assigned to: Nobody/Anonymous (nobody) Summary: Use automake srcdir/builddir locations Initial Comment: In Source/Makefile.am, there are two references to ../swig which become more robust if ../ is replaced with ${top_builddir} (specifically this breaks the way I'm personally using swig right now, of course) The patch should not affect anyone who is not trying to do anything crazy. Patch is against SVN:10172 ---------------------------------------------------------------------- >Comment By: Monty Taylor (sdirector) Date: 2007-12-04 19:11 Message: Logged In: YES user_id=43580 Originator: YES File Added: SWIG.patch ---------------------------------------------------------------------- Comment By: William Fulton (wsfulton) Date: 2007-12-03 22:54 Message: Logged In: YES user_id=242951 Originator: NO The last patch posted to swig-user contains the following. Please explain how this patch improves on things as by my reckoning, it does nothing!... +0000 ======================================= === modified file 'swig/SWIG/Source/Makefile.am' --- swig/SWIG/Source/Makefile.am 2007-11-04 21:32:20 +0000 +++ swig/SWIG/Source/Makefile.am 2007-11-26 02:02:21 +0000 @@ -98,1 +98,1 @@ 98#·The·executable·is·copied·to·the·root·directory·for·installation·and ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=301645&aid=1838248&group_id=1645 |
From: SourceForge.net <no...@so...> - 2007-12-04 19:15:30
|
Patches item #1838248, was opened at 2007-11-25 21:32 Message generated for change (Comment added) made by sdirector You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=301645&aid=1838248&group_id=1645 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: None Status: Open Resolution: None Priority: 5 Private: No Submitted By: Monty Taylor (sdirector) Assigned to: Nobody/Anonymous (nobody) Summary: Use automake srcdir/builddir locations Initial Comment: In Source/Makefile.am, there are two references to ../swig which become more robust if ../ is replaced with ${top_builddir} (specifically this breaks the way I'm personally using swig right now, of course) The patch should not affect anyone who is not trying to do anything crazy. Patch is against SVN:10172 ---------------------------------------------------------------------- >Comment By: Monty Taylor (sdirector) Date: 2007-12-04 19:15 Message: Logged In: YES user_id=43580 Originator: YES *doh* So here's the real patch. (sorry for all the versions - I seem to keep forgetting the automake 1.10 isn't in use everywhere yet. The reason this is better is in vpath builds. I've got the swig source tree embedded in my project right now to ensure its built with the right swig version. One of the things I've got that project doing as a sanity check is running make distcheck, which does a make dist and then a vpath build. The only thing that breaks in the swig tree are these paths. I don't think it should any negative impact on normal builds. ---------------------------------------------------------------------- Comment By: Monty Taylor (sdirector) Date: 2007-12-04 19:11 Message: Logged In: YES user_id=43580 Originator: YES File Added: SWIG.patch ---------------------------------------------------------------------- Comment By: William Fulton (wsfulton) Date: 2007-12-03 22:54 Message: Logged In: YES user_id=242951 Originator: NO The last patch posted to swig-user contains the following. Please explain how this patch improves on things as by my reckoning, it does nothing!... +0000 ======================================= === modified file 'swig/SWIG/Source/Makefile.am' --- swig/SWIG/Source/Makefile.am 2007-11-04 21:32:20 +0000 +++ swig/SWIG/Source/Makefile.am 2007-11-26 02:02:21 +0000 @@ -98,1 +98,1 @@ 98#·The·executable·is·copied·to·the·root·directory·for·installation·and ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=301645&aid=1838248&group_id=1645 |
From: SourceForge.net <no...@so...> - 2007-12-09 12:36:07
|
Patches item #1838248, was opened at 2007-11-25 21:32 Message generated for change (Comment added) made by wsfulton You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=301645&aid=1838248&group_id=1645 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: None >Status: Closed >Resolution: Accepted Priority: 5 Private: No Submitted By: Monty Taylor (sdirector) >Assigned to: William Fulton (wsfulton) Summary: Use automake srcdir/builddir locations Initial Comment: In Source/Makefile.am, there are two references to ../swig which become more robust if ../ is replaced with ${top_builddir} (specifically this breaks the way I'm personally using swig right now, of course) The patch should not affect anyone who is not trying to do anything crazy. Patch is against SVN:10172 ---------------------------------------------------------------------- >Comment By: William Fulton (wsfulton) Date: 2007-12-09 12:36 Message: Logged In: YES user_id=242951 Originator: NO Applied for version 1.3.34. Thanks. ---------------------------------------------------------------------- Comment By: Monty Taylor (sdirector) Date: 2007-12-04 19:15 Message: Logged In: YES user_id=43580 Originator: YES *doh* So here's the real patch. (sorry for all the versions - I seem to keep forgetting the automake 1.10 isn't in use everywhere yet. The reason this is better is in vpath builds. I've got the swig source tree embedded in my project right now to ensure its built with the right swig version. One of the things I've got that project doing as a sanity check is running make distcheck, which does a make dist and then a vpath build. The only thing that breaks in the swig tree are these paths. I don't think it should any negative impact on normal builds. ---------------------------------------------------------------------- Comment By: Monty Taylor (sdirector) Date: 2007-12-04 19:11 Message: Logged In: YES user_id=43580 Originator: YES File Added: SWIG.patch ---------------------------------------------------------------------- Comment By: William Fulton (wsfulton) Date: 2007-12-03 22:54 Message: Logged In: YES user_id=242951 Originator: NO The last patch posted to swig-user contains the following. Please explain how this patch improves on things as by my reckoning, it does nothing!... +0000 ======================================= === modified file 'swig/SWIG/Source/Makefile.am' --- swig/SWIG/Source/Makefile.am 2007-11-04 21:32:20 +0000 +++ swig/SWIG/Source/Makefile.am 2007-11-26 02:02:21 +0000 @@ -98,1 +98,1 @@ 98#·The·executable·is·copied·to·the·root·directory·for·installation·and ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=301645&aid=1838248&group_id=1645 |