From: Dmitry V. L. <ld...@al...> - 2011-05-28 20:45:35
|
On Fri, May 27, 2011 at 03:00:59PM +0200, Denys Vlasenko wrote: > diff -p option prints "what function we are in" header > before each hunk. Example: > > @@ -440,19 +440,18 @@ static void parse_config_file(void) > > strace source, however, upsets working of this option because > we have (very-)old-style C function definitions in some places. > Even though they are gradually replaced, I still often > have broken "diff -p" output which shows last parameter > declaration instead of function name. > > This patch converts all remaining old-style C function definitions > to a "modern" form. This does not change any actual code. The change is definitely OK if it really doesn't change any actual code. If you are sure there is no accidental mistake, please commit. -- ldv |
From: Denys V. <dvl...@re...> - 2011-05-30 12:03:23
|
On Sun, 2011-05-29 at 00:45 +0400, Dmitry V. Levin wrote: > On Fri, May 27, 2011 at 03:00:59PM +0200, Denys Vlasenko wrote: > > diff -p option prints "what function we are in" header > > before each hunk. Example: > > > > @@ -440,19 +440,18 @@ static void parse_config_file(void) > > > > strace source, however, upsets working of this option because > > we have (very-)old-style C function definitions in some places. > > Even though they are gradually replaced, I still often > > have broken "diff -p" output which shows last parameter > > declaration instead of function name. > > > > This patch converts all remaining old-style C function definitions > > to a "modern" form. This does not change any actual code. > > The change is definitely OK if it really doesn't change any actual code. > If you are sure there is no accidental mistake, please commit. Applied, thanks! -- vda |