#38 validate_name in Clustertab.pm disallows rfc-compliant names

closed
nobody
None
5
2004-03-31
2004-03-31
Ole Craig
No

I wanted to name my CVIP "iesl-cluster" but the install
process didn't like it. Seeing as a "-" character is a
perfectly valid hostname component, I was a bit
annoyed. (OK, maybe I'm easily peeved.)
Attached is a patch to /cluster/lib/Clustertab.pm that
fixes this.

Discussion

  • Ole Craig
    Ole Craig
    2004-03-31

    patch against openssi-rh9-1.0.0-rc3

     
    • status: open --> closed
     
  • Logged In: YES
    user_id=16302

    Thanks, Craig. I checked in your patch. I also allowed _
    characters.

    Brian

     
  • Ole Craig
    Ole Craig
    2004-03-31

    Logged In: YES
    user_id=204125

    Actually, I'm pretty sure that a hyphen is the only
    non-alphanumeric allowed by RFC921 and its successors. (I
    had occasion to look it up once; got bit by this exact regex
    when I was writing a log parser to implement POP-before SMTP
    relay authentication, and folks dialing in from
    customer-192-268.foo.bar.com complained they couldn't relay
    no matter what.)

    Cheers,
    Ole

     
  • Logged In: NO

    Underscores are not valid in RFC compliant names, only
    hyphens.

    Kind Regards,
    -dsp

     
  • Logged In: YES
    user_id=16302

    My bad. I've removed the underscore.

    Brian