SquirrelMail / Patches / #117 LSUB command needs % to show \NOSELECT "folders"

#117 LSUB command needs % to show \NOSELECT &quot;folders&quot;

Status: closed-fixed

Owner:

Labels: Folders (53)

Priority: 9

Updated: 2002-06-11

Created: 2001-08-17

Creator: Nick Sayer

Private: No

This is in 1.2.0-rc1.

The colapsable folder view doesn't work very well if
mailboxes don't exist at all of the folder branch
points. That is, if a.b and a.c exist, but not a,
then you don't get to see a +/- colapse point for a
like you should.

The fix is to append % to the LSUB command's 2nd
argument. This will report \NOSELECT nodes. I've
reported this before and it's been fixed in older
versions.

The attached file is the patch to fix it.

Discussion

Nick Sayer - 2001-08-17

Patch against 1.2.0-RC1

p

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2002-01-26

status: open --> closed-fixed
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Nick Sayer - 2002-02-23

priority: 5 --> 9

status: closed-fixed --> open-fixed
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Nick Sayer - 2002-02-23

Logged In: YES
user_id=185025

This is still not fixed in 1.2.5.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Nick Sayer - 2002-02-23

summary: LSUB command needs % to show \NOSELECT f --> LSUB command needs % to show \NOSELECT "folders"
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Nick Sayer - 2002-02-23

summary: LSUB command needs % to show \NOSELECT "folders" --> LSUB command needs % to show \NOSELECT "folders"
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Nick Sayer - 2002-02-23

Logged In: YES
user_id=185025

It should be mentioned that it is less likely one would see
this sort of thing happen if cyrus was not their imap server.

To see it, create mailboxes foo.bar and foo.baz, but do NOT
create just plain foo. In the folder view, you will see the
names bar and baz, but no indication that they live under
foo. If you add the patch, the folder foo will show up with
an option to colapse at that point, but foo will not be
selectable because it's not a mailbox.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2002-03-01

assigned_to: nobody --> ullgren

summary: LSUB command needs % to show \NOSELECT "folders" --> LSUB command needs % to show \NOSELECT "folders"
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Pontus Ullgren - 2002-03-03

status: open-fixed --> closed-fixed
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Pontus Ullgren - 2002-03-03

Logged In: YES
user_id=61176

Patch applied also added check so that it is impossible to
delete a \Noselect node since this will generate an error.

(OT: Deleteing any folder generates error in the current CVS
(2002-03-03) due to the filter plugin)

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2002-06-03

assigned_to: ullgren --> jmunro

status: closed-fixed --> open-fixed
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2002-06-03

Logged In: YES
user_id=442854

re-opening this because several IMAP servers are having
problems with this LSUB command. It appears that they will
simply return an empty list instead of a list of folders
because of the "%". I suggest we make a "/noselect node
reporting" option in conf.pl to keep everybody happy :)

jason
jason@stdbev.com

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Pontus Ullgren - 2002-06-03

Logged In: YES
user_id=61176

Can't we use the imap_server_type instead ?
Saves us alot of diffrent settings.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Nick Sayer - 2002-06-03

Logged In: YES
user_id=185025

For what it's worth, servers that don't do trailing '%'
correctly are in violation of the IMAP RFC. But I do agree
that making it optional is probably the best thing.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2002-06-03

Logged In: YES
user_id=442854

I know. If only IMAP servers would follow the IMAP RFC, then
I would get a lot more sleep at night :)

jason
jason@stdbev.com

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2002-06-11

status: open-fixed --> closed-fixed
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anonymous - 2002-06-11

Logged In: YES
user_id=442854

OK, its now an option in conf.pl, menu #3, option 18. The %
will be left off the LSUB command by default as it breaks
several IMAP servers. Applied to both the dev and stable
branches.

jason
jason@stdbev.com

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Log in to post a comment.