From: Bruce H. <br...@po...> - 2005-09-30 01:51:14
|
I've done a search of this list, but haven't found anything regarding this issue. A customer of ours brought this to our attention. We are running Squirrelmail 1.4.5, html_mail 2.2.1.4 1) Press the "Compose" button to bring up the normal composition window. 2) Click on the "Addresses" button above the composition text area. 3) Select an address from the address book and click "Use Addresses" 4) Try to click on the "Compose in HTML" link and it will generate an error. The problem is that the link is generated in an invalid format: http://squirrelmaildomain.tld/src/compose.php&comp_in_html=1 It seems to be missing the "?" to separate the query string. Any ideas? |
From: Paul L. <pa...@sq...> - 2005-09-30 03:35:04
|
Bruce Hellstrom wrote: > I've done a search of this list, but haven't found anything regarding > this issue. A customer of ours brought this to our attention. > > We are running Squirrelmail 1.4.5, html_mail 2.2.1.4 > > 1) Press the "Compose" button to bring up the normal composition window. > 2) Click on the "Addresses" button above the composition text area. > 3) Select an address from the address book and click "Use Addresses" > 4) Try to click on the "Compose in HTML" link and it will generate an > error. > > The problem is that the link is generated in an invalid format: > > http://squirrelmaildomain.tld/src/compose.php&comp_in_html=1 > > It seems to be missing the "?" to separate the query string. Nice find. Look in functions.php, around line 49, for a line like this: echo '<a href="' . $PHP_SELF . '&comp_in_html=1">'. _("Compose in HTML") . '</a>'; Change it to: echo '<a href="' . $PHP_SELF . (strpos($PHP_SELF, '?') === FALSE ? '?' : '&') . 'comp_in_html=1">'. _("Compose in HTML") . '</a>'; This is untested, so please let me know. Cheers, Paul -- __________________________ Open Guild, LLC http://openguild.net/ Software.Systems.Solutions |
From: Bruce H. <br...@po...> - 2005-11-08 00:19:40
|
Hi Paul, Took a long time for me to implement this since it is a minor issue, but the fix below appears to work fine. Thanks. Paul Lesneiwski wrote: >Bruce Hellstrom wrote: > > >>I've done a search of this list, but haven't found anything regarding >>this issue. A customer of ours brought this to our attention. >> >>We are running Squirrelmail 1.4.5, html_mail 2.2.1.4 >> >>1) Press the "Compose" button to bring up the normal composition window. >>2) Click on the "Addresses" button above the composition text area. >>3) Select an address from the address book and click "Use Addresses" >>4) Try to click on the "Compose in HTML" link and it will generate an >>error. >> >>The problem is that the link is generated in an invalid format: >> >>http://squirrelmaildomain.tld/src/compose.php&comp_in_html=1 >> >>It seems to be missing the "?" to separate the query string. >> >> > >Nice find. > >Look in functions.php, around line 49, for a line like this: > >echo '<a href="' . $PHP_SELF . '&comp_in_html=1">'. _("Compose in HTML") >. '</a>'; > >Change it to: > >echo '<a href="' . $PHP_SELF . (strpos($PHP_SELF, '?') === FALSE ? '?' : >'&') . 'comp_in_html=1">'. _("Compose in HTML") . '</a>'; > >This is untested, so please let me know. > >Cheers, > > Paul > > |