From: Thierry G. <mel...@ya...> - 2008-02-01 10:26:05
|
Greetings ! Two more patches (bugfixes) for Squirrelmail (SVN devel branch): - squirrelmail-20080201-SVN_devel-X-PriorityLow.patch: fixes a problem with Low Importance/Priority in functions/imap_messages.php (decoded as priority level 3 instead of 5). - squirrelmail-20080201-SVN_devel-RFC2047encodedAddresses.patch: fixes a problem where addresses in from/to/cc/bcc fields are not properly decoded whenever accented characters are used in the name or surname for long addresses format. Regards, Thierry Godefroy. ____________________________________________________________________________________ Never miss a thing. Make Yahoo your home page. http://www.yahoo.com/r/hs |
From: Paul L. <pa...@sq...> - 2008-02-05 04:38:26
|
> Two more patches (bugfixes) for Squirrelmail (SVN devel branch): Thanks so very much. > - squirrelmail-20080201-SVN_devel-X-PriorityLow.patch: fixes a problem with Low > Importance/Priority in functions/imap_messages.php (decoded as priority level 3 > instead of 5). Well caught. Has been committed. > - squirrelmail-20080201-SVN_devel-RFC2047encodedAddresses.patch: fixes a > problem where addresses in from/to/cc/bcc fields are not properly decoded > whenever accented characters are used in the name or surname for long > addresses format. Hmmm, I just tested with a user in my address book with the two following characters: ö and é. I have the full email format set to show up when I add it to my message. It seemed to work. Can you provide more details on the issue? Maybe I need to test with some other characters or with a different language turned on. Note that the same comments apply here about the fact that the sanitization will be going away soon, although I realize we aren't dealing with that issue alone. |
From: Thierry G. <mel...@ya...> - 2008-02-05 09:09:00
|
--- Paul Lesniewski <pa...@sq...> wrote: > > Two more patches (bugfixes) for Squirrelmail (SVN devel branch): > > Thanks so very much. > > > - squirrelmail-20080201-SVN_devel-X-PriorityLow.patch: fixes a problem with > Low > > Importance/Priority in functions/imap_messages.php (decoded as priority > level 3 > > instead of 5). > > Well caught. Has been committed. > > > - squirrelmail-20080201-SVN_devel-RFC2047encodedAddresses.patch: fixes a > > problem where addresses in from/to/cc/bcc fields are not properly decoded > > whenever accented characters are used in the name or surname for long > > addresses format. > > Hmmm, I just tested with a user in my address book with the two > following characters: ö and é. I have the full email format set to > show up when I add it to my message. It seemed to work. Can you > provide more details on the issue? Maybe I need to test with some > other characters or with a different language turned on. Note that > the same comments apply here about the fact that the sanitization will > be going away soon, although I realize we aren't dealing with that > issue alone. Simply send yourself an email from Thunderbird, for example, using accented characters in the To field (for example): Thunderbird will use RFC2047 encoding on the To field, and SQM will fail to decode it... Regards, Thierry. ____________________________________________________________________________________ Never miss a thing. Make Yahoo your home page. http://www.yahoo.com/r/hs |
From: Thijs K. <ki...@sq...> - 2008-05-06 15:15:07
|
On Friday 1 February 2008 11:25, Thierry Godefroy wrote: > - squirrelmail-20080201-SVN_devel-RFC2047encodedAddresses.patch: fixes a > problem where addresses in from/to/cc/bcc fields are not properly decoded > whenever accented characters are used in the name or surname for long > addresses format. Thanks. This was indeed a devel-specific bug which is now fixed. Note that your patch wasn't entirely correct (I don't know if you use it locally): you add a "false" parameter to htmlspecialchars which I think shouldn't be there, and the htmlspecialchars+decodeHeader leads to double HTML encoding, because decodeHeader already delivers the result HTML-safe by default. cheers, Thijs |