Menu

#2 One broken diff causes all subsquent tests to seem to fail

closed-accepted
None
5
2004-05-28
2004-04-19
Ken Kress
No

I tried submitting a bug, but I don't see it in the bug
database. Anyway, I spent some time on this and found
a simple solution to the problem, which I've pasted
below and uploaded as an attachment. It just clears the
errorMessage after the failure has been logged.

--- sqlunit/SQLUnit.java Tue Feb 03 02:40:15 2004
+++ sqlunit_krk/SQLUnit.java Mon Apr 19
00:20:50 2004
@@ -227,6 +227,7 @@
}
long endTime = System.currentTimeMillis();
log(" (" + (endTime - startTime) + "ms)");
+
if (errorMessage != null) {
log(errorMessage);
}
@@ -235,7 +236,10 @@
// routing based on haltOnFailure setting
if (errorMessage != null) {
if (haltOnFailure) { break; }
- else { continue; }
+ else {
+ errorMessage = null; // 20040417: KRK
+ continue;
+ }
}
}
// teardown the test

Discussion

  • Ken Kress

    Ken Kress - 2004-04-19

    Patch file to add one line to SQLUnit.java

     
  • Sujit Pal

    Sujit Pal - 2004-05-22

    Logged In: YES
    user_id=184803

    Hi Ken,

    I did not see the patch, before this, but I have started
    monitoring this page, so I will know from now on. Thank you
    for the patch, and I will incorporate it into the next release.

    -sujit

     
  • Sujit Pal

    Sujit Pal - 2004-05-28
    • assigned_to: nobody --> spal
    • status: open --> closed-accepted
     

Log in to post a comment.