Thread: [SQL-CVS] [ sqlobject-Patches-1414091 ] Fix cache cleanup for new object creation
SQLObject is a Python ORM.
Brought to you by:
ianbicking,
phd
From: SourceForge.net <no...@so...> - 2006-01-24 22:04:45
|
Patches item #1414091, was opened at 2006-01-24 14:04 Message generated for change (Tracker Item Submitted) made by Item Submitter You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=540674&aid=1414091&group_id=74338 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: None Status: Open Resolution: None Priority: 5 Submitted By: Peter Kropf (peterk) Assigned to: Nobody/Anonymous (nobody) Summary: Fix cache cleanup for new object creation Initial Comment: The existing CacheFactory doesn't call cull() on new object creation. As a result, the amount of memory consumed by a program continues to grow without bounds. In addition, cull was never being called on get (object lookup) operations because the cullCount variable was not being incrimented. The attached patch (generated via svn diff) fixes sqlobject/cache.py so that cull is called from created() and cullCount is incrimented for each get / created call. There's also a new test case in sqlobject/tests/test_cache.py that attempts to check for the condition where new object creation doesn't result in culling. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=540674&aid=1414091&group_id=74338 |
From: SourceForge.net <no...@so...> - 2006-01-31 15:44:48
|
Patches item #1414091, was opened at 2006-01-25 01:04 Message generated for change (Comment added) made by phd You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=540674&aid=1414091&group_id=74338 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: None >Status: Closed >Resolution: Accepted Priority: 5 Submitted By: Peter Kropf (peterk) >Assigned to: Oleg Broytmann (phd) Summary: Fix cache cleanup for new object creation Initial Comment: The existing CacheFactory doesn't call cull() on new object creation. As a result, the amount of memory consumed by a program continues to grow without bounds. In addition, cull was never being called on get (object lookup) operations because the cullCount variable was not being incrimented. The attached patch (generated via svn diff) fixes sqlobject/cache.py so that cull is called from created() and cullCount is incrimented for each get / created call. There's also a new test case in sqlobject/tests/test_cache.py that attempts to check for the condition where new object creation doesn't result in culling. ---------------------------------------------------------------------- >Comment By: Oleg Broytmann (phd) Date: 2006-01-31 18:44 Message: Logged In: YES user_id=4799 Applied to the trunk at the revision 1554. Thank you! ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=540674&aid=1414091&group_id=74338 |