Overview: Lots of small changes in this branch, all but one in src/SolidMaterial
.
- Fundumental physical constants
- Modified:
src/Material/PhysicalConstants.cc
src/SolidMaterial/ANEOS.cc
- Boltzmann's constant was way off due to typo.
- I took the opportunity to update all other constants to the current (2013) CRC Handbook.
Most changes are tiny of course, but note that G was changed a 4th decimal place in 2006
and again in 2010, which could be important for self gravity runs.
- The updated values also meant an updated ev-to-Kelvin coeeficient in ANEOS
- Specific heat definition
- Modified:
src/SolidMaterial/TillotsonEquationOfState.cc
src/SolidMaterial/MurnagahnEquaionOfState.cc
src/SolidMaterial/LinearPolynomialEquationOfState.cc
- The constructor of the above EOSs calculated specific heat per unit volume instead of
per unit mass.
- I found these files by grep-ing, did I miss any?
- Specific heat usage
- Modified:
src/SolidMaterial/TillotsonEquationOfState.cc
src/SolidMaterial/MurnagahnEquaionOfState.cc
src/SolidMaterial/LinearPolynomialEquationOfState.cc
- The energy/temperature relation, eps=Cv*dT, was backwards, in the
temperature()
and
specificthermalEnergy()
methods of these EOSs.
- I grep-ed for similar bugs, but I could have missed some. Where else can Cv be used?
- Dimensioned atomic weight
- Modified:
src/SolidMaterial/ShadowTillotsonEquationOfState.py
src/SolidMaterial/MaterialPropertiesLib.py
- Added conversion to user supplied units to the values read from library
- Fixed the comments in the library dict to avoid confusion
- Specific heat setter methods
- Modified:
src/SolidMaterial/TillotsonEquationOfState.cc
src/SolidMaterial/MurnagahnEquaionOfState.cc
src/SolidMaterial/LinearPolynomialEquationOfState.cc
src/SolidMaterial/ANEOS.cc
- The
setSpecificThermalEnergy()
method of these EOSs was using values from the
empty specific energy vector itself instead of from the passed temperature array.
- Did I miss any other places where this could happen?
Okay to close branch after merging. But it will still appear n the SF code browser! Annoying.
-naor
Accepted Naor's changes and verified our standard test set is passing.