From: Erwan V. <er...@ma...> - 2003-10-30 11:16:31
|
Hi, I'm the packager of Smartmontools at MandrakeSoft and I don't understand why you consider mandrake as unsupported whereas it works and regulary released. 5.1.22 has been built this morning :) --=20 Erwan Velu Linux Cluster Distribution Project Manager MandrakeSoft 43 rue d'aboukir 75002 Paris Phone Number : +33 (0) 1 40 41 17 94 Fax Number : +33 (0) 1 40 41 92 00 Web site : http://www.mandrakesoft.com OpenPGP key : http://www.mandrakesecure.net/cks/=20 |
From: Bruce A. <ba...@gr...> - 2003-10-30 12:35:38
|
Hi Erwan, > Hi, I'm the packager of Smartmontools at MandrakeSoft and I don't > understand why you consider mandrake as unsupported whereas it works > and regulary released. This is my fault, and I apologize. Many distributions package smartmontools with their own init script, and I had assumed that Mandrake was doing that as well. If not, could you have a quick look at smartd.initd.in and tell us which of the init scripts you want us to use for Mandrake? Or send us your prefered script? I'll then remove the warning message for the next release. > 5.1.22 has been built this morning :) Thank you! Cheers, Bruce |
From: Erwan V. <er...@ma...> - 2003-10-30 12:41:56
|
> This is my fault, and I apologize. Many distributions package > smartmontools with their own init script, and I had assumed that Mandrake > was doing that as well. =20 This is not the case since the first package ;-) > >If not, could you have a quick look at smartd.initd.in and tell us which= of the init scripts you want us to use > for Mandrake? Or send us your prefered script? I'll then remove the > warning message for the next release. We are currently using the same as your use for redhat (we are providing /e= tc/redhat-release :-) ). The only very small patch I use is to define also "reload" which do the same as restart. --=20 Erwan Velu Linux Cluster Distribution Project Manager MandrakeSoft 43 rue d'aboukir 75002 Paris Phone Number : +33 (0) 1 40 41 17 94 Fax Number : +33 (0) 1 40 41 92 00 Web site : http://www.mandrakesoft.com OpenPGP key : http://www.mandrakesecure.net/cks/=20 |
From: Bruce A. <ba...@gr...> - 2003-10-30 12:55:11
|
I've just modified the distribution version to read like this: # Red Hat or Yellow Dog or Mandrake if [ -f /etc/redhat-release -o -f /etc/yellowdog-release -o -f /etc/mandrake-release ] ; then # Source function library . /etc/rc.d/init.d/functions case "$1" in start) echo -n "Starting smartd: " daemon /usr/sbin/smartd touch /var/lock/subsys/smartd echo ;; stop) echo -n "Shutting down smartd: " killproc smartd rm -f /var/lock/subsys/smartd echo ;; restart) $0 stop $0 start ;; reload) $0 stop $0 start ;; status) status smartd ;; *) echo "Usage: smartd {start|stop|restart|reload|status}" exit 1 esac exit 0 # Slackware elif [ -f /etc/slackware-release ] ; then ... Is this OK so that you can use it in Mandrake without patching? Cheers, Bruce On Thu, 30 Oct 2003, Erwan Velu wrote: > > This is my fault, and I apologize. Many distributions package > > smartmontools with their own init script, and I had assumed that Mandrake > > was doing that as well. > This is not the case since the first package ;-) > > > >If not, could you have a quick look at smartd.initd.in and tell us which of the init scripts you want us to use > > for Mandrake? Or send us your prefered script? I'll then remove the > > warning message for the next release. > > We are currently using the same as your use for redhat (we are providing /etc/redhat-release :-) ). > The only very small patch I use is to define also "reload" which do the > same as restart. > > -- > Erwan Velu > Linux Cluster Distribution Project Manager > MandrakeSoft > 43 rue d'aboukir 75002 Paris > Phone Number : +33 (0) 1 40 41 17 94 > Fax Number : +33 (0) 1 40 41 92 00 > Web site : http://www.mandrakesoft.com > OpenPGP key : http://www.mandrakesecure.net/cks/ > |
From: Erwan V. <er...@ma...> - 2003-10-30 12:58:26
|
>Is this OK so that you can use it in Mandrake without patching? exactly ! It sounds cool :) Thx, --=20 Erwan Velu Linux Cluster Distribution Project Manager MandrakeSoft 43 rue d'aboukir 75002 Paris Phone Number : +33 (0) 1 40 41 17 94 Fax Number : +33 (0) 1 40 41 92 00 Web site : http://www.mandrakesoft.com OpenPGP key : http://www.mandrakesecure.net/cks/=20 |
From: Bruce A. <ba...@gr...> - 2003-10-30 13:10:39
|
> >Is this OK so that you can use it in Mandrake without patching? > exactly ! It sounds cool :) It's checked into CVS, will be in 5.23. Note that when I can incorporate changes like this upstream, without breaking anything, I'm happy to do so. Just let me know. Bruce |
From: Bruce A. <ba...@gr...> - 2003-10-31 09:26:28
|
Erwan, I just realized this morning that perhaps the reload target should NOT do the same thing as restart. Don't you want "reload" to reload the config file? In which case we should have: ;; reload) echo -n $"Reloading $prog: " killproc /usr/sbin/smartd -HUP RETVAL=$? echo return $RETVAL ;; We might also want to have a "report" option: report) echo -n $"Reloading $prog: " killproc /usr/sbin/smartd -USR1 RETVAL=$? echo return $RETVAL ;; What do you think? Cheers, Bruce On Thu, 30 Oct 2003, Bruce Allen wrote: > I've just modified the distribution version to read like this: > > > # Red Hat or Yellow Dog or Mandrake > if [ -f /etc/redhat-release -o -f /etc/yellowdog-release -o -f > /etc/mandrake-release ] ; then > > # Source function library > . /etc/rc.d/init.d/functions > > case "$1" in > start) > echo -n "Starting smartd: " > daemon /usr/sbin/smartd > touch /var/lock/subsys/smartd > echo > ;; > stop) > echo -n "Shutting down smartd: " > killproc smartd > rm -f /var/lock/subsys/smartd > echo > ;; > restart) > $0 stop > $0 start > ;; > reload) > $0 stop > $0 start > ;; > status) > status smartd > ;; > *) > echo "Usage: smartd {start|stop|restart|reload|status}" > exit 1 > esac > > exit 0 > > # Slackware > elif [ -f /etc/slackware-release ] ; then > ... > > Is this OK so that you can use it in Mandrake without patching? > > Cheers, > Bruce > > On Thu, 30 Oct 2003, Erwan Velu wrote: > > > > This is my fault, and I apologize. Many distributions package > > > smartmontools with their own init script, and I had assumed that Mandrake > > > was doing that as well. > > This is not the case since the first package ;-) > > > > > >If not, could you have a quick look at smartd.initd.in and tell us which of the init scripts you want us to use > > > for Mandrake? Or send us your prefered script? I'll then remove the > > > warning message for the next release. > > > > We are currently using the same as your use for redhat (we are providing /etc/redhat-release :-) ). > > The only very small patch I use is to define also "reload" which do the > > same as restart. > > > > -- > > Erwan Velu > > Linux Cluster Distribution Project Manager > > MandrakeSoft > > 43 rue d'aboukir 75002 Paris > > Phone Number : +33 (0) 1 40 41 17 94 > > Fax Number : +33 (0) 1 40 41 92 00 > > Web site : http://www.mandrakesoft.com > > OpenPGP key : http://www.mandrakesecure.net/cks/ > > > > > > ------------------------------------------------------- > This SF.net email is sponsored by: SF.net Giveback Program. > Does SourceForge.net help you be more productive? Does it > help you create better code? SHARE THE LOVE, and help us help > YOU! Click Here: http://sourceforge.net/donate/ > _______________________________________________ > Smartmontools-support mailing list > Sma...@li... > https://lists.sourceforge.net/lists/listinfo/smartmontools-support > > |
From: Bruce A. <ba...@gr...> - 2003-10-31 09:35:32
|
I should have said: reload) echo -n $"Reloading smartd.conf: " killproc /usr/sbin/smartd -HUP RETVAL=$? echo exit $RETVAL ;; report) echo -n $"Checking devices now: " killproc /usr/sbin/smartd -USR1 RETVAL=$? echo exit $RETVAL ;; On Fri, 31 Oct 2003, Bruce Allen wrote: > Erwan, > > I just realized this morning that perhaps the reload target should NOT do > the same thing as restart. Don't you want "reload" to reload the config > file? In which case we should have: > > ;; > reload) > echo -n $"Reloading $prog: " > killproc /usr/sbin/smartd -HUP > RETVAL=$? > echo > return $RETVAL > ;; > > We might also want to have a "report" option: > > report) > echo -n $"Reloading $prog: " > killproc /usr/sbin/smartd -USR1 > RETVAL=$? > echo > return $RETVAL > ;; > > What do you think? > > Cheers, > Bruce > > > On Thu, 30 Oct 2003, Bruce Allen wrote: > > > I've just modified the distribution version to read like this: > > > > > > # Red Hat or Yellow Dog or Mandrake > > if [ -f /etc/redhat-release -o -f /etc/yellowdog-release -o -f > > /etc/mandrake-release ] ; then > > > > # Source function library > > . /etc/rc.d/init.d/functions > > > > case "$1" in > > start) > > echo -n "Starting smartd: " > > daemon /usr/sbin/smartd > > touch /var/lock/subsys/smartd > > echo > > ;; > > stop) > > echo -n "Shutting down smartd: " > > killproc smartd > > rm -f /var/lock/subsys/smartd > > echo > > ;; > > restart) > > $0 stop > > $0 start > > ;; > > reload) > > $0 stop > > $0 start > > ;; > > status) > > status smartd > > ;; > > *) > > echo "Usage: smartd {start|stop|restart|reload|status}" > > exit 1 > > esac > > > > exit 0 > > > > # Slackware > > elif [ -f /etc/slackware-release ] ; then > > ... > > > > Is this OK so that you can use it in Mandrake without patching? > > > > Cheers, > > Bruce > > > > On Thu, 30 Oct 2003, Erwan Velu wrote: > > > > > > This is my fault, and I apologize. Many distributions package > > > > smartmontools with their own init script, and I had assumed that Mandrake > > > > was doing that as well. > > > This is not the case since the first package ;-) > > > > > > > >If not, could you have a quick look at smartd.initd.in and tell us which of the init scripts you want us to use > > > > for Mandrake? Or send us your prefered script? I'll then remove the > > > > warning message for the next release. > > > > > > We are currently using the same as your use for redhat (we are providing /etc/redhat-release :-) ). > > > The only very small patch I use is to define also "reload" which do the > > > same as restart. > > > > > > -- > > > Erwan Velu > > > Linux Cluster Distribution Project Manager > > > MandrakeSoft > > > 43 rue d'aboukir 75002 Paris > > > Phone Number : +33 (0) 1 40 41 17 94 > > > Fax Number : +33 (0) 1 40 41 92 00 > > > Web site : http://www.mandrakesoft.com > > > OpenPGP key : http://www.mandrakesecure.net/cks/ > > > > > > > > > > > ------------------------------------------------------- > > This SF.net email is sponsored by: SF.net Giveback Program. > > Does SourceForge.net help you be more productive? Does it > > help you create better code? SHARE THE LOVE, and help us help > > YOU! Click Here: http://sourceforge.net/donate/ > > _______________________________________________ > > Smartmontools-support mailing list > > Sma...@li... > > https://lists.sourceforge.net/lists/listinfo/smartmontools-support > > > > > > > > ------------------------------------------------------- > This SF.net email is sponsored by: SF.net Giveback Program. > Does SourceForge.net help you be more productive? Does it > help you create better code? SHARE THE LOVE, and help us help > YOU! Click Here: http://sourceforge.net/donate/ > _______________________________________________ > Smartmontools-support mailing list > Sma...@li... > https://lists.sourceforge.net/lists/listinfo/smartmontools-support > > |
From: Erwan V. <er...@ma...> - 2003-10-31 09:51:31
|
Le ven 31/10/2003 =E0 10:26, Bruce Allen a =E9crit : > I just realized this morning that perhaps the reload target should NOT do > the same thing as restart. Don't you want "reload" to reload the config > file? In which case we should have: Good idea but you can't really exit with retval. RETVAL=3D0 case "$1" in [cut] reload) echo -n $"Reloading smartd.conf: " killproc /usr/sbin/smartd -HUP RETVAL=3D$? echo ;; report) echo -n $"Checking devices now: " killproc /usr/sbin/smartd -USR1 RETVAL=3D$? echo ;; [cut] then exit $RETVAL instead of exit 0 This way is cleaner, --=20 Erwan Velu Linux Cluster Distribution Project Manager MandrakeSoft 43 rue d'aboukir 75002 Paris Phone Number : +33 (0) 1 40 41 17 94 Fax Number : +33 (0) 1 40 41 92 00 Web site : http://www.mandrakesoft.com OpenPGP key : http://www.mandrakesecure.net/cks/=20 |