From: matthieu c. <cas...@fr...> - 2008-02-23 11:08:50
Attachments:
atacb.diff
|
Hi, I have implemented atacb support for smartmontools, only for smartctl ATM. I only did some basic test on a cypress usb bridge. Why on http://smartmontools.sourceforge.net/smartmontools_scsi.html, atacb is said to only work when there no other access ? Matthieu |
From: Bruce A. <ba...@gr...> - 2008-03-18 06:03:36
|
Hi Matthieu, This might be a good time to add your code to CVS. I've added you to the developers list so you can write to CVS. (Christian, this is a pretty simple patch so I don't think it will complicate the new device interface to put this in now.) Cheers, Bruce On Sat, 23 Feb 2008, matthieu castet wrote: > Hi, > > I have implemented atacb support for smartmontools, only for smartctl ATM. > > I only did some basic test on a cypress usb bridge. > > > Why on http://smartmontools.sourceforge.net/smartmontools_scsi.html, atacb is > said to only work when there no other access ? > > > Matthieu > |
From: Christian F. <Chr...@t-...> - 2008-03-18 20:54:06
|
Hi Bruce, Hi Matthieu, > Hi Matthieu, > > This might be a good time to add your code to CVS. I've added you to the > developers list so you can write to CVS. > > (Christian, this is a pretty simple patch so I don't think it will > complicate the new device interface to put this in now.) > > It makes sense to check this in soon, before further refactoring steps are done. From the device interface view this is similar to SAT: it implements an "ata_interface" by using a "scsi_interface". (See scsiata.cpp in my last draft for an example) Cheers, Christian |
From: matthieu c. <cas...@fr...> - 2008-03-19 21:21:35
|
Hi, Christian Franke wrote: > Hi Bruce, Hi Matthieu, >> Hi Matthieu, >> >> This might be a good time to add your code to CVS. I've added you to >> the developers list so you can write to CVS. >> Ok, I will try to commit it this weekend. I have some cleaning to do. >> (Christian, this is a pretty simple patch so I don't think it will >> complicate the new device interface to put this in now.) >> >> > > It makes sense to check this in soon, before further refactoring steps > are done. > > From the device interface view this is similar to SAT: it implements an > "ata_interface" by using a "scsi_interface". Yes this is very similar to SAT. Only the scsi command format is different (and the fact there can be 2 command instead of one). Matthieu |
From: Bruce A. <ba...@gr...> - 2008-03-23 21:27:45
|
Hi Matthieu, I have a new external USB/Firewire disk to play with (Maxtor OneTouch 4 plus, 500 GB) and thought I would try out your code. (I don't know if this box has a Cypress chipset or something else, so it might not work properly). Anyway, I found that your patch did not apply cleanly because it is done with 'cvs diff'. Could you produce a patch with standard diff, or even better, check your changes into smartmontools CVS so I can try them out? Cheers, Bruce On Sat, 23 Feb 2008, matthieu castet wrote: > Hi, > > I have implemented atacb support for smartmontools, only for smartctl ATM. > > I only did some basic test on a cypress usb bridge. > > > Why on http://smartmontools.sourceforge.net/smartmontools_scsi.html, atacb is > said to only work when there no other access ? > > > Matthieu > |
From: matthieu c. <cas...@fr...> - 2008-03-23 22:54:40
|
Hi Bruce, Bruce Allen wrote: > Hi Matthieu, > > I have a new external USB/Firewire disk to play with (Maxtor OneTouch 4 > plus, 500 GB) and thought I would try out your code. (I don't know if > this box has a Cypress chipset or something else, so it might not work > properly). Anyway, I found that your patch did not apply cleanly > because it is done with 'cvs diff'. > > Could you produce a patch with standard diff, or even better, check your > changes into smartmontools CVS so I can try them out? Commited ;) I hope I didn't break anything. Matthieu |