From: Petr G. <pg...@su...> - 2007-03-08 09:28:23
Attachments:
smartmontools-array_subscript.patch
|
Hi, I'm solving bug (https://bugzilla.novell.com/show_bug.cgi?id=239956) in package smartmontools-5.36. Program reads from unallocated memory in the last iteration of for on line 722 of file os_linux.cpp. Is it OK to replace string 'CIS_MAX_LUN+1' with 'CIS_MAX_LUN' in the end condition? Thanks Petr |
From: Petr G. <pg...@su...> - 2007-03-07 10:05:25
Attachments:
smartmontools-array_subscript.patch
|
Hi, I'm solving bug (https://bugzilla.novell.com/show_bug.cgi?id=239956) in package smartmontools-5.36. Program reads from unallocated memory in the last iteration of for on line 722 of file os_linux.cpp. Is it OK to replace string 'CIS_MAX_LUN+1' with 'CIS_MAX_LUN' in the end condition? Thanks Petr |
From: Christian F. <Chr...@t-...> - 2007-03-12 19:53:57
|
Petr Gajdos wrote: > Hi, > I'm solving bug (https://bugzilla.novell.com/show_bug.cgi?id=239956) in > package smartmontools-5.36. Program reads from unallocated memory in the > last iteration of for on line 722 of file os_linux.cpp. Is it OK to > replace string > 'CIS_MAX_LUN+1' > with > 'CIS_MAX_LUN' > in the end condition? > Looks good, CISS_MAX_LUN actually specifies the MAX number of LUNs (16), not the MAX value. Guido? BTW: CISS_MAX_LUN is redefined to same value after first use: os_linux.cpp: typedef struct _ReportLUNdata_struct { BYTE LUNListLength[4]; DWORD reserved; BYTE LUN[CISS_MAX_LUN][8]; } ReportLunData_struct; ... #define CISS_MAX_LUN 16 Cheers, Christian |
From: Guido G. <ag...@si...> - 2007-03-14 21:37:01
Attachments:
ws-cleanup.diff
|
Hi Christian, On Mon, Mar 12, 2007 at 08:53:34PM +0100, Christian Franke wrote: > Petr Gajdos wrote: > >Hi, > >I'm solving bug (https://bugzilla.novell.com/show_bug.cgi?id=239956) in > >package smartmontools-5.36. Program reads from unallocated memory in the > >last iteration of for on line 722 of file os_linux.cpp. Is it OK to > >replace string > >'CIS_MAX_LUN+1' > >with > >'CIS_MAX_LUN' > >in the end condition? > > > > Looks good, CISS_MAX_LUN actually specifies the MAX number of LUNs (16), > not the MAX value. > > Guido? Looks correct. In case you didn't fix this already I applied a patch that also cleans up all the trailing white spaces - I'm currently a bit bandwitdh limited, so either please apply or I'll do so when back in netland... -- Guido |
From: Christian F. <Chr...@t-...> - 2007-03-21 20:35:58
|
Guido Guenther wrote: > Hi Christian, > ... >> Guido? >> > Looks correct. In case you didn't fix this already I applied a patch > that also cleans up all the trailing white spaces - I'm currently a bit > bandwitdh limited, so either please apply or I'll do so when back in > netland... > > Applied. Christian |
From: Petr G. <pg...@su...> - 2007-03-09 08:35:03
Attachments:
smartmontools-array_subscript.patch
|
Hi, I'm solving bug (https://bugzilla.novell.com/show_bug.cgi?id=239956) in package smartmontools-5.36. Program reads from unallocated memory in the last iteration of for on line 722 of file os_linux.cpp. Is it OK to replace string 'CIS_MAX_LUN+1' with 'CIS_MAX_LUN' in the end condition? Thanks Petr |