From: Steve L. (JIRA) <ji...@sm...> - 2008-03-27 14:27:39
|
TestCompound doesnt appear to handle exit types on actions correctly -------------------------------------------------------------------- Key: SFOS-752 URL: http://jira.smartfrog.org/jira/browse/SFOS-752 Project: SmartFrog Issue Type: Bug Components: .sfCore Affects Versions: 3.12.029 dev Reporter: Steve Loughran Assignee: Steve Loughran Fix For: 3.12.029 dev I'm saying 'doesnt' appear' as I need to understand more what is going on. TestCompound is deploying something that fails abnormally, and it thinks this is ok. even though it isnt. testAbnormalRun extends ExpectTerminate { description "this is expected to fail with an error"; //condition NotConditionSet; action extends FailAbnormal { normal false; message "oops!"; } } This should fail, but it does not. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.smartfrog.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira |
From: Steve L. (JIRA) <ji...@sm...> - 2008-03-27 15:25:43
|
[ http://jira.smartfrog.org/jira/browse/SFOS-752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=10971#action_10971 ] Steve Loughran commented on SFOS-752: ------------------------------------- fixed in SVN. The problem was we used : if (childStatus.errorType.contains(exitType)) { when we should have really compared on .equals(); Why? "abnormal".contains("normal") evaluates true -any test that expected normal and got abnormal would have passed. When we expected normal and got abnormal, the tests would have correctly detected the failure. > TestCompound doesnt appear to handle exit types on actions correctly > -------------------------------------------------------------------- > > Key: SFOS-752 > URL: http://jira.smartfrog.org/jira/browse/SFOS-752 > Project: SmartFrog > Issue Type: Bug > Components: .sfCore > Affects Versions: 3.12.029 dev > Reporter: Steve Loughran > Assignee: Steve Loughran > Fix For: 3.12.029 dev > > Original Estimate: 2 hours > Remaining Estimate: 2 hours > > I'm saying 'doesnt' appear' as I need to understand more what is going on. TestCompound is deploying something that fails abnormally, and it thinks this is ok. even though it isnt. > testAbnormalRun extends ExpectTerminate { > description "this is expected to fail with an error"; > //condition NotConditionSet; > action extends FailAbnormal { > normal false; > message "oops!"; > } > } > This should fail, but it does not. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.smartfrog.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira |
From: Steve L. (JIRA) <ji...@sm...> - 2008-03-27 17:07:55
|
[ http://jira.smartfrog.org/jira/browse/SFOS-752?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Loughran resolved SFOS-752. --------------------------------- Resolution: Fixed fixed! > TestCompound doesnt appear to handle exit types on actions correctly > -------------------------------------------------------------------- > > Key: SFOS-752 > URL: http://jira.smartfrog.org/jira/browse/SFOS-752 > Project: SmartFrog > Issue Type: Bug > Components: .sfCore > Affects Versions: 3.12.029 dev > Reporter: Steve Loughran > Assignee: Steve Loughran > Fix For: 3.12.029 dev > > Original Estimate: 2 hours > Remaining Estimate: 2 hours > > I'm saying 'doesnt' appear' as I need to understand more what is going on. TestCompound is deploying something that fails abnormally, and it thinks this is ok. even though it isnt. > testAbnormalRun extends ExpectTerminate { > description "this is expected to fail with an error"; > //condition NotConditionSet; > action extends FailAbnormal { > normal false; > message "oops!"; > } > } > This should fail, but it does not. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.smartfrog.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira |