From: barry <sla...@i1...> - 2001-11-10 04:06:39
|
Below are 2 bug reports I have (bugzilla style, so the order is inverted). Basically I discovered that some templates use variables that don't exist in the table "vars", or do exist but the spelling of the name does not match between the table and the templates. - Perhaps this information can be added to an errata note in the readme for bender? - Does anyone else know of similar issues? - Can I add these new variables to the table via the admin interface, or do I have to do it via sql? Thanks! Barry Bug reports follow: ############################################################################ Missing email address: > Problems regarding accounts or comment posting should be sent to . ------- Additional Comments From barry 2001-11-10 19:57 ------- in edit_comment;comments;default: was: <A HREF="mailto:[% constants.admin_mail %]">[% constants.admin_name %] </A>.</FONT> now: <A HREF="mailto:[% constants.adminmail %]">[% constants.admin_name %] </A>.</FONT> Also, created variable admin_name in table vars: mysql> insert into vars values ("admin_name","the site administrator","admin name for use in edit_comments- should match the value in users table"); Query OK, 1 row affected (0.00 sec) ------- Additional Comments From barry 2001-11-10 20:08 ------- [root@slash templates]# grep admin_mail * errors;comments;default:[% constants.admin_mail %]. If you are being a troll, now is the time for you to changed to: [% constants.adminmail %]. If you are being a troll, now is the time for you to ############################################################## [root@slash templates]# grep admin_name * dispTheComments;metamod;default:[% constants.siteadmin_name.uc %]!</B> <P>What follows is [% constants.m2_comments %] random messages;users;default: email <A HREF="mailto:[% constants.adminmail %]">[% constants.siteadmin_name %]</A>. messages;users;default: [% constants.siteadmin_name %] Calls to constants.siteadmin_name need to be changed to constants.admin_name: dispTheComments;metamod;default: [% constants.admin_name.uc %]!</B> <P>What follows is [% constants.m2_comments %] random messages;users;default: email <A HREF="mailto:[% constants.adminmail %]">[% constants.admin_name %]</A>. and: [% constants.admin_name %] |
From: Jamie M. <ja...@mc...> - 2001-11-10 18:05:24
|
sla...@i1... (barry) writes: > Basically I discovered that some templates use variables that > don't exist in the table "vars", or do exist but the spelling of > the name does not match between the table and the templates. > ------- Additional Comments From barry 2001-11-10 19:57 ------- > in edit_comment;comments;default: > > was: > > <A HREF="mailto:[% constants.admin_mail %]">[% > constants.admin_name %] > </A>.</FONT> > > now: > <A HREF="mailto:[% constants.adminmail %]">[% constants.admin_name > %] > </A>.</FONT> That was fixed in CVS in June. http://cvs.slashcode.com/index.cgi/slash/themes/slashcode/templates/edit_comment;comments;default.diff?r1=1.2.2.3&r2=1.2.2.4 > Also, created variable admin_name in table vars: > > mysql> insert into vars values ("admin_name","the site > administrator","admin > name for use in edit_comments- should match the value in users table"); > Query OK, 1 row affected (0.00 sec) Don't do that; use the var 'siteadmin_name'. > [root@slash templates]# grep admin_mail * > errors;comments;default:[% constants.admin_mail %]. If you are being a > troll, > now is the time for you to > > changed to: > > [% constants.adminmail %]. If you are being a troll, now is the time for > you to That was fixed in CVS in August. http://cvs.slashcode.com/index.cgi/slash/themes/slashcode/templates/errors;comments;default.diff?r1=1.2.2.8&r2=1.2.2.9 > Calls to constants.siteadmin_name need to be changed to > constants.admin_name: No, they don't; siteadmin_name is the name of the var we picked, it may be ugly but let's continue to use it please :) -- Jamie McCarthy ja...@mc... |
From: barry <sla...@i1...> - 2001-11-10 18:16:23
|
At 01:05 PM 11/10/2001 -0500, you wrote: > > Calls to constants.siteadmin_name need to be changed to > > constants.admin_name: > >No, they don't; siteadmin_name is the name of the var we picked, >it may be ugly but let's continue to use it please :) OK - I had a 50/50 chance of guessing the right one. I will change my code. Thanks! Barry |