#1298 author handling

Slashdot Beta
closed-fixed
Rob Malda
Admin (123)
7
2001-09-15
2001-09-07
Michael Sims
No

bug 1 - authors don't show up on authors.pl unless
they have the authors checkbox checked (i.e., only
*current* authors are shown, not historical authors).

bug 2 - something in admin.pl or submit.pl unsets the
author checkbox in everyday use (I believe it is
admin.pl). It unsets the checkbox for whoever the
current author on the submission/story is. I've had
it happen with new submissions and with op=edit,
editing stories already in place.

Discussion

  • Michael Sims
    Michael Sims
    2001-09-07

    • assigned_to: nobody --> pudge
     
  • Jamie McCarthy
    Jamie McCarthy
    2001-09-08

    • priority: 5 --> 7
     
  • Jamie McCarthy
    Jamie McCarthy
    2001-09-08

    Logged In: YES
    user_id=3889

    I'm bumping up priority on this, it's important. Also note that Cliff said on IRC Friday night "Hmmm... Think I found out why author flags keep getting unset. It's a theory at this point. Will test later. Need food now." So you might want to check with him on this, maybe bribe him with food or something.

     
  • Chris Nandor
    Chris Nandor
    2001-09-11

    Logged In: YES
    user_id=3660

    OK, the first part of this is fixed and committed.
    getAuthors() now takes an optional arrayref for its $no_cache
    argument, where the arrayref is a list of UIDs to get instead
    of looking in the DB for active authors.

     
  • Chris Nandor
    Chris Nandor
    2001-09-12

    Logged In: YES
    user_id=3660

    OK, Cliff and I tracked down the bad author problem. Fix
    committed.

     
  • Chris Nandor
    Chris Nandor
    2001-09-12

    • assigned_to: pudge --> cmdrtaco
    • status: open --> open-fixed
     
  • Michael Sims
    Michael Sims
    2001-09-13

    Logged In: YES
    user_id=307358

    The fix has changed the default author - now when one hits "Preview" the first time to turn a submission
    into a would-be story, the author listed is always CmdrTaco (first entry in the drop-down) instead of the
    actual logged-in author. The entry in the drop-down box that corresponds to whoever I am logged-in as
    should have "SELECTED" and does not.

     
  • Chris Nandor
    Chris Nandor
    2001-09-13

    Logged In: YES
    user_id=3660

    jellicle, I don't see what you see. I hit "Preview" and see
    "pudge". The code submitted didn't touch either submit.pl or
    admin.pl, or the methods that either one uses, so the code
    submitted for these fixes shouldn't have cause any problem
    you are seeing, regardless (the affected files were only
    authors.pl and users.pl). If you still have the problem, it
    must be related to something else; please submit a separate
    bug report.

     
  • Rob Malda
    Rob Malda
    2001-09-15

    • status: open-fixed --> closed-fixed