Menu ▾ ▴

#248 Remove libpurple SSL configure check

OBSOLETE_(1.18.x)
closed-fixed
Stefan Becker
None
Pidgin
5
2016-04-23
2014-05-19
Eion Robb
No

Hi there,

A user has reported a bug in the pidgin-opensteamworks plugin https://code.google.com/p/pidgin-opensteamworks/issues/detail?id=78 that they can't compile pidgin-sipe if they have the Steam plugin installed. The Steam plugin expects there to be a Core/UI set up, but the ./configure script test doesn't provide one, so segfaults.

I would propose that SSL plugin checking shouldn't be a compile-time check in pidgin-sipe but should be a run-time check instead.

Related

Release Notes: 2014/06/pidgin-sipe-release-1182

Discussion

  • Stefan Becker

    Stefan Becker - 2014-05-20
    • summary: SSL check shouldn't be compile-time --> Remove libpurple SSL configure check
    • status: open --> closed-fixed
    • assigned_to: Stefan Becker
     

  • Stefan Becker

    Stefan Becker - 2014-05-20

    The analysis of the crash in the original bug report is incorrect. The root cause is that the Steam plugin can only be loaded by a libpurple instance initialized with purple_core_init().

    My first try was to change the configure check to call purple_core_init() instead of the stripped-down initialization code, but that version caused it to fail on other platforms it was previously working on.

    I've now opted to remove the check completely in git commit f79a5d6

    Closing as FIXED.

     

Log in to post a comment.