From: Alex G. <mr....@gm...> - 2012-10-15 06:28:15
|
The weekend is over, and so is my little endeavour to make my 22-812 work with sigrok. It works. Well, everything except LOGIC functionality. This one's a doozie, as the DMM outputs LO if the voltage is < 1V, HI if the voltage is > 2V, and the actual voltage if the voltage is between 1 and 2 volts. The rest of the stuff works, and that's what really matters; unless you guys have specific objections on how the coding was done. Alex |
From: Alex G. <mr....@gm...> - 2012-10-15 06:32:14
Attachments:
0002-serial-Trivial-add-support-for-4800-baud.patch
|
Patch 2 needed a small fix. fixed. Alex On 10/15/2012 01:28 AM, Alex G. wrote: > The weekend is over, and so is my little endeavour to make my 22-812 > work with sigrok. > > It works. Well, everything except LOGIC functionality. This one's a > doozie, as the DMM outputs LO if the voltage is < 1V, HI if the voltage > is > 2V, and the actual voltage if the voltage is between 1 and 2 volts. > > The rest of the stuff works, and that's what really matters; unless you > guys have specific objections on how the coding was done. > > Alex > |
From: Peter S. <pe...@st...> - 2012-10-15 14:44:21
|
Alex G. wrote: > Subject: [PATCH 2/4] serial: (Trivial) add support for 4800 baud .. > +++ b/libsigrok/hardware/common/serial.c > @@ -218,6 +218,9 @@ SR_PRIV int serial_set_params(int fd, int baudrate, int bits, int parity, > case 9600: > dcb.BaudRate = CBR_9600; > break; > + case 9600: > + dcb.BaudRate = CBR_4800; > + break; Really? //Peter |
From: Alex G. <mr....@gm...> - 2012-10-15 14:57:08
|
On 10/15/2012 09:44 AM, Peter Stuge wrote: > Alex G. wrote: >> Subject: [PATCH 2/4] serial: (Trivial) add support for 4800 baud > .. >> +++ b/libsigrok/hardware/common/serial.c >> @@ -218,6 +218,9 @@ SR_PRIV int serial_set_params(int fd, int baudrate, int bits, int parity, >> case 9600: >> dcb.BaudRate = CBR_9600; >> break; >> + case 9600: >> + dcb.BaudRate = CBR_4800; >> + break; > > Really? > > > //Peter > A little slow today, Peter? I sent the corrected patch2 to the list yesterday. Alex |
From: Peter S. <pe...@st...> - 2012-10-15 15:09:34
|
Alex G. wrote: > A little slow today, Peter? Well, I replied before reading the full thread. :) > I sent the corrected patch2 to the list yesterday. It looks good! //Peter |
From: Alex G. <mr....@gm...> - 2012-10-15 16:00:41
|
On 10/15/2012 10:09 AM, Peter Stuge wrote: > Alex G. wrote: >> A little slow today, Peter? > > Well, I replied before reading the full thread. :) > I feel your pain. This _always_ happens to me. Though not as painful as replying on IRC to someone that has already left the channel. > >> I sent the corrected patch2 to the list yesterday. > > It looks good! > Cool! :) Alex |
From: Bert V. <be...@bi...> - 2012-10-15 16:30:40
|
On 10/15/2012 08:28 AM, Alex G. wrote: > The weekend is over, and so is my little endeavour to make my 22-812 > work with sigrok. > > It works. Well, everything except LOGIC functionality. This one's a > doozie, as the DMM outputs LO if the voltage is < 1V, HI if the voltage > is > 2V, and the actual voltage if the voltage is between 1 and 2 volts. > > The rest of the stuff works, and that's what really matters; unless you > guys have specific objections on how the coding was done. Great stuff, thanks! I've merged it. By all means add support for that DMM's LOGIC functionality. The way it returns completely different units depending on the value makes it suitable for SR_DF_ANALOG. Ah, those crazy multimeter manufacturers. -- Bert Vermeulen be...@bi... email/xmpp |
From: Alex G. <mr....@gm...> - 2012-10-15 20:01:18
|
On 10/15/2012 11:30 AM, Bert Vermeulen wrote: > On 10/15/2012 08:28 AM, Alex G. wrote: >> The weekend is over, and so is my little endeavour to make my 22-812 >> work with sigrok. >> >> It works. Well, everything except LOGIC functionality. This one's a >> doozie, as the DMM outputs LO if the voltage is < 1V, HI if the voltage >> is > 2V, and the actual voltage if the voltage is between 1 and 2 volts. >> >> The rest of the stuff works, and that's what really matters; unless you >> guys have specific objections on how the coding was done. > > Great stuff, thanks! I've merged it. > Awesome! :) > By all means add support for that DMM's LOGIC functionality. The way it > returns completely different units depending on the value makes it suitable > for SR_DF_ANALOG. Ah, those crazy multimeter manufacturers. > I was thinking about sending a SR_DF_LOGIC packet when it displays high or low, and a SR_DF_ANALOG when it displays the actual voltage. I'm not yet sure this is the best way. Alex |