#6600 SCI: Castle of Dr Brain - kUnLoad error after loading a game

closed-fixed
None
5
2014-08-07
2014-06-01
misterhands
No

Using a recent Win32 build by Kirben
Castle of Dr Brain DOS English version 1.1

After loading a savegame made during the 2nd word game, and entering the game
(you may need to move the cursor over the word grid to trigger the crash):
parameter 0: 0000:0085 (integer), should be null, integer
parameter 1: 0022:08d1 (reference, invalid), should be null, integer, reference
[VM] kUnLoad[1]: signature mismatch via method SWord::upDate (room 320, script 377, localCall 0xffffffff)!

Clicking on the EXIT button before the crash gives a similar error, only the method is different:
parameter 0: 0000:0085 (integer), should be null, integer
parameter 1: 0022:08d1 (reference, invalid), should be null, integer, reference
[VM] kUnLoad[1]: signature mismatch via method theWord::show (room 320, script 377, localCall 0xffffffff)!

Bug #4942 was about the same issue, and it was supposed to be fixed.
https://sourceforge.net/p/scummvm/bugs/4942/

Also found some irc logs about this:
http://echelog.com/logs/browse/scummvm/1279922400

1 Attachments

Discussion

    • status: open --> closed-fixed
    • assigned_to: Filippos Karapetis
     
  • Fixed properly, by allowing invalid references in kUnload() in commit 1cbfe02bcf.

    Since the reference will be invalidated anyway by kUnload itself,
    there's no real reason to check for its validity. We do the same with
    kGraph() and kDisplay().