Two issues regarding popups
1(Suggestion). Users should be able to select Popup Item using right mouse button(Currently, only left mouse button click does).
Rationale: "You should permit the user to choose an item from a shortcut menu by using the same mouse button used to display the menu." (citing http://msdn.microsoft.com/en-us/library/windows/desktop/ms647558%28v=vs.85%29.aspx#_win32_Creating_a_Shortcut_Menu)
FIX: provide TPM_RIGHTBUTTON flag to TrackPopupMenu (http://msdn.microsoft.com/en-us/library/windows/desktop/ms648002%28v=vs.85%29.aspx)
2(Question). When user click right mouse button on scintilla control, selection is removed and popup is shown. Shouldn't there be an option to retain selection when it happens? Currently, I commented corresponding line out in windows implementation. Compare: Notepad and Akelpad retain selection, but Visual Studio does not.
Committed right click as [35820f] and [ce0990].
Right clicks are about the object being pointed at. Right click over selection retains selection and displays context menu for that selection. Right click outside selection moves selection there and then displays corresponding context menu. This issue has been discussed and the behaviour changed several times before reaching the current consensus.
Related
Commit: [ce0990]
Commit: [35820f]