Menu

#299 Call Tip popup cutting off top of Japanese characters

Bug
closed-rejected
Scintilla (812)
3
2007-11-23
2005-05-24
Forest
No

The Call Tip popup window is cutting off the top of
Japanese characters. This makes many Japanese
characters unreadable.

I have made a fix for this and it looks good in both
Japanese and English.

2 Fixes in CallTip.cxx:

------------------------------------------------------------
CallTip::PaintContents
------------------------------------------------------------
line 138:
// To make a nice small call tip window, it is only
sized to fit most normal characters without accents
int ascent = surfaceWindow->Ascent(font) /*-
surfaceWindow->InternalLeading(font)*/;

*** Don't subtract the InternalLeading

------------------------------------------------------------
CallTip::CallTipStart
------------------------------------------------------------
line 253:

// Extra line for border and an empty line at top and

bottom
int height = lineHeight * numLines /*-
surfaceMeasure->InternalLeading(font)*/ + 2 + 2;

*** Don't subtract the InternalLeading

Discussion

  • Forest

    Forest - 2005-05-24

    CallTip.cxx

     
  • Forest

    Forest - 2005-05-24

    CallTip_ENU.JPG

     
  • Forest

    Forest - 2005-05-24

    CallTip_JPN.JPG

     
  • Forest

    Forest - 2005-05-24

    CallTip_JPN_NoFix.JPG

     
  • Neil Hodgson

    Neil Hodgson - 2005-05-25
    • priority: 5 --> 3
    • assigned_to: nobody --> nyamatongwe
    • status: open --> open-rejected
     
  • Neil Hodgson

    Neil Hodgson - 2005-05-25

    Logged In: YES
    user_id=12579

    I think that this adds too much space for the main use case
    which is for ASCII function parameters. A modification that
    looked at the actual text would be better.

     
  • Forest

    Forest - 2005-05-25

    Logged In: YES
    user_id=1092645

    I attached a screen shot of the space used with the fix for
    ASCII characters in CallTip_ENU.JPG. It looks good to me.

     
  • Neil Hodgson

    Neil Hodgson - 2005-05-26

    Logged In: YES
    user_id=12579

    There are 2 pixels of extra space at the top making it look
    unbalanced.

     
  • Forest

    Forest - 2005-05-26

    Logged In: YES
    user_id=1092645

    Yeah, you are right. I'm sure there is a more robust fix,
    but this fix is better than not having unreadable Japanese.
    (at least for me) I will do my own build until this is
    addressed in a public release.

    Thanks for the great edit control.

     
  • Neil Hodgson

    Neil Hodgson - 2007-11-23
    • status: open-rejected --> closed-rejected
     

Log in to post a comment.