Menu

#1730 missing includes

Bug
closed-rejected
scintilla (590)
2
2015-06-20
2015-05-31
mberchtold
No

The following is a list of files with missing includes:

File: src/Document.h

include <stdexcept> // for std::runtime_error

include "CaseFolder.h"

include "Decoration.h"

File: src/EditView.h

include "EditModel.h"

include "PositionCache.h"

include "MarginView.h" // for DrawWrapMarkerFn

File: src/Editor.h

include <algorithm>

include <string>

include "EditView.h"

include "MarginView.h"

include "PositionCache.h"

include "Selection.h"

File: src/ExternalLexer.h

include <string>

include "LexerModule.h"

File: src/MarginView.h

include "EditModel.h"

File: src/Partitioning.h

include "SplitVector.h"

File: src/PositionCache.h

include "Selection.h"

File: src/RunStyles.h

include "Partitioning.h"

File: src/Selection.h

include <vector>

File: src/XPM.h

include

include <vector>

File: lexlib/Accessor.h

include "LexAccessor.h"

File: lexlib/LexAccessor.h

include <cassert>

include "ILexer.h"

File: src/CallTip.h

include <string>

It would be great if you can add them.

Discussion

  • mberchtold

    mberchtold - 2015-05-31

    I did not intend to format it this way :-( Could you format it the correct way as I do not seem to have sufficient permissions to edit the post.

     

    Last edit: mberchtold 2015-05-31
  • Neil Hodgson

    Neil Hodgson - 2015-05-31

    The policy in Scintilla is no #include statements inside headers. This avoids producing a twisted ball of includes.

     
  • Neil Hodgson

    Neil Hodgson - 2015-05-31
    • labels: --> scintilla
    • status: open --> open-rejected
    • assigned_to: Neil Hodgson
     
  • Neil Hodgson

    Neil Hodgson - 2015-06-20
    • status: open-rejected --> closed-rejected
     

Log in to post a comment.