#1707 open filters not working properly in open dialog in windows

[L505]

I downloaded the latest version of Scite from the website, or compiled it from the sources and still have the same problem. I can't get the open filters working properly for the open dialog in windows.

Verilog, TeX, Pascal, and other filters are not showing in the drop down menu. To get them working I moved them to the top of the open.filter list in the sciteglobal.properties file (non alphabetical). As soon as I put them back to their original alphabetical positions they do not work any more. They are not commented out, they are enabled and they don't show up in the drop down menu of the open dialog.

I realize that the all source files filter is limited to 256 characters or similar, but what could be wrong with individual filters? why does juggling around the filters make them work (disabling others as a side effect)?

Filters that do show up are ones like Ada, perl, lua, and more. If you count the total items in the drop down menu of the open dialog, they are less than the total count that are enabled in the sciteglobal.properties file.

[Neil Hodgson]

The original mechanism for avoiding entries in open.filter was to comment them out as, for example, #$(filter.ch). Later, the imports.exclude property was added so that these files would not be read so would not provide any properties. Thus $(filter.powershell) evaluates to empty since powershell.properties isn't read. However, despite modula3 being in imports.exclude, it is still commented out as #$(filter.modula3)\ which then evaluates to "#" which then appears before the Pascal filter (the intervening filters are all missing/empty) as "#Pascal (dpr dpk pas dfm inc pp)|.dpr;.dpk;.pas;.dfm;.inc;.pp|" which is then discarded as a comment.

The solution is to remove the '#' from filters that are turned off with imports.exclude: haskell, modula3, and rust. Then add hex to imports.exclude as it is also rarely used and remove the # from ihex, tehex, and srec. That leaves $(filter.ch) which is for a rarely used C interpreter included in cpp.properties, so move it beyond the end as a comment.

Committed as [9673ef].

[L505]

thanks I removed the pound signs in the open filter list and this fixes the problem, I'm just surprised that I am the first one to notice/report this.