Scintilla / Bugs / #1412 LexHTML: JavaScript RegExp literal not always recognized

#1412 LexHTML: JavaScript RegExp literal not always recognized

Milestone: Bug

Status: closed-fixed

Owner: Neil Hodgson

Labels: Scintilla (812) lexer (143)

Priority: 5

Updated: 2013-04-01

Created: 2012-10-18

Creator: Anonymous

Private: No

ColouriseHyperTextDoc considers a RegExp literal only as such if it's preceded by '(', '=' or ',' (see isOKBeforeRE). This is inconsistent with what LexerCPP::Lex uses (any of "([{=,:;!%^&*|?~+-") and causes the attached testcase to be wrongly colored. Is there a valid reason for the divergence between LexHTML's and LexCPP's lists? Otherwise thanks for extending LexHTML's list to match LexCPP's.

Discussion

Comment has been marked as spam.
Undo

View and moderate all "bugs Discussion" comments posted by this user

Mark all as spam, and block user from posting to "Bugs"

Anonymous - 2012-10-18

minimal testcase

Last edit: Anonymous 2014-12-05

minimal testcase

Add attachments
Cancel
You seem to have CSS turned off. Please don't fill out this field.

You seem to have CSS turned off. Please don't fill out this field.

New Attachment:

testcase.html

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Neil Hodgson - 2012-12-30

They were identical when added but LexCPP was changed with https://sourceforge.net/tracker/?func=detail&aid=1777016&group_id=2439&atid=102439

I won't be working on this myself.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Neil Hodgson - 2012-12-30

assigned_to: nobody --> nyamatongwe

milestone: --> Bug

status: open --> open-accepted
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

zeniko - 2013-03-10

This patch extends the list to match most of LexCPP's as requested. For the time being, it just still fails in two even rarer edge cases which have since been fixed for LexCPP.

fix.patch

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Neil Hodgson - 2013-03-11

labels: Scintilla --> Scintilla, lexer

status: open-accepted --> open-fixed
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Neil Hodgson - 2013-03-11

Committed fix as [b042cc].

Related

Commit: [b042cc]

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Neil Hodgson - 2013-04-01

status: open-fixed --> closed-fixed
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Log in to post a comment.