Learn how easy it is to sync an existing GitHub or Google Code repo to a SourceForge project! See Demo

Close

#2721 wbemcli doesn't accept baseline dot in username/password

Code_Cleanup
closed-fixed
Dave Heller
None
wbemcli
5
2014-10-14
2014-02-04
No

Hello,

wbemcli doesn't accept baseline dot ('.', 46 ASCII) character in username/password part of the URL, because it's considered as key/host delimiter, even if it's positioned before auth token delimiter ('@').

Attached patch fixes this issue.

1 Attachments

Discussion

  • Dave Heller
    Dave Heller
    2014-02-22

    Thanks for pointing this out.

    After looking at it a bit, I'm not sure what is the purpose of checking for '.' at this point to begin with. We end up overwriting the value of p after the 1st conditional, in all cases, so it's only relevant to that 1st conditional, which is the block of code that parses the user:password. And we shouldn't care about '.' in the user:password. I don't know what the original intent was, but as as it stands it looks like this code does nothing at all (except cause a bug!)

    Indeed, your patch simply advances the ptr to '.' to a value to the right of '@'... which really just ensures the following conditional is always true... and then we discard p. So it's all starting to look useless.

    Am I missing something? Does not the attached patch do the same thing?

    I tested with a URL like:

    wbemcli gi 'http://user.id:pass.w0rd@[fe80::aaaa:bbbb:cccc:dddd%eth0]:5988/root/cimv2:Linux_ComputerSystem.CreationClassName="Linux_ComputerSystem",Name="myhost.mydomain.com"'
    
     
  • Dave Heller
    Dave Heller
    2014-03-04

    Committed to CVS

     
  • Dave Heller
    Dave Heller
    2014-03-04

    • status: open --> pending-fixed
     
  • Dave Heller
    Dave Heller
    2014-10-14

    • status: pending-fixed --> closed-fixed
    • assigned_to: Dave Heller