#1955 CIMQualifierElementInterfaceImpl changes qualifiers

[Philip Warren]

The CIMQualifierElementInterfaceImpl class changes existing qualifiers to match the KEY/ASSOCIATION predefined classes. For example:

CIMQualifier<Boolean> keyQualifier = new CIMQualifier<Boolean>("key",CIMDataType.BOOLEAN_T, Boolean.TRUE, CIMFlavor.DISABLEOVERRIDE, true);
CIMClassProperty<?> prop = new CIMClassProperty<String>("prop", CIMDataType.STRING_T,"val", new CIMQualifier<?>[] { keyQualifier }, true, true, null);
System.out.println(prop.getQualifier("key").isPropagated());

The keyQualifier passed to the CIMClassProperty constructor had the propagated attribute set to true, however after creating the CIMClassProperty with this qualifier, the propagated attribute was changed to false. A similar issue occurs with the association key and the CIMClass constructor.

It would be nice if the attributes of existing keys could be preserved (as long as they have the same value). This would allow the propagated attribute to be preserved and any CIM flavors to be preserved.

[Philip Warren]

[Dave Blaschke]

For replacing "key" qualifier, logic will be:

} else if (!pQuali.getValue().equals(this.iQualis[idx].getValue())) {

instead of:

} else if (!Boolean.TRUE.equals(this.iQualis[idx])) {

Will not worry about changing the removal of "key" qualifier for now, that might have farther-reaching side effects - the client has always removed the "key" qualifier if pIsKeyed==false, so not removing it in certain situations might break folks.

[Dave Blaschke]

Proposed patch breaks 3 unit tests

[Dave Blaschke]

Note that this change will only affect qualifiers with name = "key" or "association" - all other qualifiers are unaffected

[Dave Blaschke]

Patch sent for community review. During a 2 week period any
exploiter may comment on the patch, request changes or turn it
down completely (with good reason). For the time being the patch is part of the "Experimental" branch in CVS.

[Dave Blaschke]

Patch against HEAD

[Dave Blaschke]

The community review has completed and we received no substantial critisism. Therefore the patch has been approved and merged into the "HEAD" branch. The next release will pick it up.

[Dave Blaschke]

The patch was picked up by release 2.1.5 and will therefore be closed.