From: Nikodemus S. <nik...@ra...> - 2006-05-17 12:15:07
Attachments:
sbcl-home.patch
|
Cheers, -- Nikodemus Schemer: "Buddha is small, clean, and serious." Lispnik: "Buddha is big, has hairy armpits, and laughs." |
From: Thiemo S. <th...@ne...> - 2006-05-17 12:39:42
|
Nikodemus Siivola wrote: > Subject says pretty much all of it. > > I'd like to make make.sh accept a second command-line argument, which > is used as the INSTALL_ROOT by install.sh, and also as basis for the > default (built-in) SBCL_HOME. Additionally, I'd like make.sh to > default it in a platform dependent manner, so that Windows builds a > nicer default then /usr/local/... > > The attached patch is one way of doing this. > > (It also incorporates the s/sbcl/$RUNTIME/ patch, and gets rid of > ensure_dirs that has a hard time with directories that have whitespace > in their names -- but those are orthogonal to the main issue, albeit > necessary for install.sh operation on Windows.) > > (Oh, and it also centralized the BUILD_ROOT noise. Another orthogonal > part, sorry.) > > Objections (1) to doing something like this in general (2) against > this patch specifically? Add a bit of documentation how it works, mentioning output/sbcl-target-{root,home}.txt ? Thiemo |
From: Rudi S. <ru...@co...> - 2006-05-18 09:18:22
Attachments:
PGP.sig
|
On 17. Mai 2006, at 14:14, Nikodemus Siivola wrote: > Subject says pretty much all of it. > > I'd like to make make.sh accept a second command-line argument, which > is used as the INSTALL_ROOT by install.sh, and also as basis for the > default (built-in) SBCL_HOME. Additionally, I'd like make.sh to > default it in a platform dependent manner, so that Windows builds a > nicer default then /usr/local/... I think that's a good idea in general. The windows case might need some further thought, though, because an sbcl built on a German windows system will have problems on an English one (c:\Programme \sbcl vs c:\Program Files\sbcl). I fear that hardcoding SBCL_HOME will lose in any case on windows. Cheers, Rudi |
From: Nikodemus S. <nik...@ra...> - 2006-05-18 09:35:37
|
Rudi Schlatte <ru...@co...> writes: > I think that's a good idea in general. The windows case might need > some further thought, though, because an sbcl built on a German > windows system will have problems on an English one (c:\Programme > \sbcl vs c:\Program Files\sbcl). I fear that hardcoding SBCL_HOME > will lose in any case on windows. Right. And install.sh isn't the way to go about Windows installation anyways in the long run. Even if we don't bother with an MSI it should be install.bat in the minimum. Cheers, -- Nikodemus Schemer: "Buddha is small, clean, and serious." Lispnik: "Buddha is big, has hairy armpits, and laughs." |
From: <mar...@gm...> - 2006-05-19 06:59:34
|
Q291cGxlIG9mIG9ic2VydmF0aW9ucyBmb3IgV2luZG93cyBJbnN0YWxsZXIuCgoxIC0gT25lIGNh biBnZXQgdGhlIGxvY2F0aW9uIG9mIHByb2dyYW0gZmlsZXMgdXNpbmcgJVByb2dyYW1GaWxlcyUs CmVnLiBvbiBteSBYUApDOlw+ZWNobyAlUHJvZ3JhbUZpbGVzJQpDOlxQcm9ncmFtIEZpbGVzCkkg c3VwcG9zZSB0aGVyZSBpcyBhIHNwZWNpYWwgZm9sZGVyIGZvciB0aGF0IHRvbyAoc2ltaWxhciB0 byB3aGF0Cllhcm9zbGF2IG9mZmVyZWQgZm9yIHVzZXIgaG9tZWRpciBwYXRjaCkKCjIgLSBJdCBp cyBub3QgaW4gc3Bpcml0IG9mIHdpbmRvd3MgdG8gaGF2ZSBmaWxlcyBzY2F0dGVyZWQgdGhyb3Vn aG91dAp0aGUgc3lzdGVtIGFzIGZvciBsaW51eCBpcy4gTWF5YmUgYmV0dGVyIHdheSBpcyB0byBw dXQgc2JjbC5leGUgaW4KU0JDTF9IT01FIGFuZCBrZWVwIGV2ZXJ5dGhpbmcgaW4gb25lIGZvbGRl ci4gSWYgc28sIFNCQ0xfSE9NRSB1bmRlcgp3aW5kb3dzIHdvdWxkbid0IGV2ZW4gYmUgbmVlZGVk LCBhcyBpZiBpdCBpcyBub3QgcHJlc2VudCBpdCBjb3VsZCBiZQphc3N1bWVkIHRvIGJlIHRoZSBz YW1lIGZvbGRlciB3aGVyZSBzYmNsLmV4ZSBpcywgd2hpY2ggbGVhZHMgdXMgdG86CgozIC0gTVNJ IHdvdWxkIGJlIGFuIG92ZXJraWxsLiBBIHNpbXBsZSB6aXAgd291bGQgYmUgZW5vdWdoIChhbHJl YWR5CnByZXBhY2thZ2VkLCB3aXRob3V0IGluc3RhbGwuc2gpLiBJZiBpbnN0YWxsZXIgaXMgcmVh bGx5IG5lZWRlZCwgb25lCmNvdWxkIGJlIG1hZGUgZmFpcmx5IGVhc3kgYW5kIHF1aWNrIHVzaW5n IElubm9TZXR1cCB3aGljaCBpcyBmcmVlLgoKUmVnYXJkcywKTWFya28K |
From: Nikodemus S. <nik...@ra...> - 2006-05-19 08:03:11
|
"Marko Kocić" <mar...@gm...> writes: > 1 - One can get the location of program files using %ProgramFiles%, This is what the current install.sh does, and how that patch picks the default location. > I suppose there is a special folder for that too (similar to what > Yaroslav offered for user homedir patch) I believe the environment variable is actually magic, and what you have is the special folder underneath. > 2 - It is not in spirit of windows to have files scattered throughout > the system as for linux is. Maybe better way is to put sbcl.exe in > SBCL_HOME and keep everything in one folder. If so, SBCL_HOME under > windows wouldn't even be needed, as if it is not present it could be > assumed to be the same folder where sbcl.exe is, which leads us to: Sure, but then the core-finding logic is different on different platforms, which isn't good. The files aren't scattered anyhow: both the current install.sh and put files under Program Files/SBCL by default -- in a manner comperable to /opt/sbcl on posixoid systems. Thanks for the comments. Cheers, -- Nikodemus Schemer: "Buddha is small, clean, and serious." Lispnik: "Buddha is big, has hairy armpits, and laughs." |