From: NIIMI S. <sa...@sa...> - 2005-06-15 01:47:45
Attachments:
eucjp.diff
eucjp.lisp.bz2
|
Hi, Attached are patch and source code to support EUC-JP encoding as external format. These can be applied to both HEAD and 0.9.1. Thanks, -- NIIMI Satoshi |
From: Nikodemus S. <nik...@ra...> - 2005-06-15 06:33:09
|
On Wed, 15 Jun 2005, NIIMI Satoshi wrote: > Attached are patch and source code to support EUC-JP encoding as > external format. _Very_ cool. In fd-stream.lisp you have - (incf tail size) - (incf start))) + (incf tail size))) ...which looks a bit dubious. What's it about? A test-case for eucJP input and output (reading and writing a bit, and checking that the results are right) would be good. Cheers, -- Nikodemus Schemer: "Buddha is small, clean, and serious." Lispnik: "Buddha is big, has hairy armpits, and laughs." |
From: NIIMI S. <sa...@sa...> - 2005-06-15 07:19:52
|
On 2005/06/15 15:33, Nikodemus Siivola wrote: > In fd-stream.lisp you have > > - (incf tail size) > - (incf start))) > + (incf tail size))) > > ...which looks a bit dubious. What's it about? The code with or without output-restart must be identical. See the counterpart in define-external-format macro. I think the mistake has been left because there was no external format with variable width and output-restart. > A test-case for eucJP input and output (reading and writing a bit, and > checking that the results are right) would be good. I'll try. Thanks, -- NIIMI Satoshi |
From: NIIMI S. <sa...@sa...> - 2005-06-15 12:09:50
Attachments:
eucjp.lisp.diff
eucjp-test.tar.bz2
|
Okay, I've made a test-case for EUC-JP. Thanks to the test, I've found a typo in eucjp.lisp, which is fixed by attached patch. ;-) Thanks, -- NIIMI Satoshi |
From: Rudi S. <ru...@co...> - 2005-06-16 14:24:38
Attachments:
PGP.sig
|
On 15. Jun 2005, at 14:09, NIIMI Satoshi wrote: > Okay, I've made a test-case for EUC-JP. > > Thanks to the test, I've found a typo in eucjp.lisp, which is fixed > by attached patch. ;-) > Many thanks, committed as 0.9.1.47. If something's missing, give me a shout. Regards, Rudi |