On Wed, 15 Jun 2005, NIIMI Satoshi wrote:
> Attached are patch and source code to support EUC-JP encoding as
> external format.
In fd-stream.lisp you have
- (incf tail size)
- (incf start)))
+ (incf tail size)))
...which looks a bit dubious. What's it about?
A test-case for eucJP input and output (reading and writing a bit, and
checking that the results are right) would be good.
-- Nikodemus Schemer: "Buddha is small, clean, and serious."
Lispnik: "Buddha is big, has hairy armpits, and laughs."
On 2005/06/15 15:33, Nikodemus Siivola wrote:
> In fd-stream.lisp you have
> - (incf tail size)
> - (incf start)))
> + (incf tail size)))
> ...which looks a bit dubious. What's it about?
The code with or without output-restart must be identical. See the
counterpart in define-external-format macro.
I think the mistake has been left because there was no external format
with variable width and output-restart.
> A test-case for eucJP input and output (reading and writing a bit, and
> checking that the results are right) would be good.
On 15. Jun 2005, at 14:09, NIIMI Satoshi wrote:
> Okay, I've made a test-case for EUC-JP.
> Thanks to the test, I've found a typo in eucjp.lisp, which is fixed
> by attached patch. ;-)
Many thanks, committed as 0.9.1.47. If something's missing, give me