Menu

#163 Code coverage is computed even if shell variable SASUNIT_COVERAGEASSESSMENT is set to 0

v1.6
closed
None
v1.5
SAS_9.3_Windows
Defect_Report
unknown
3-moderate
2015-06-29
2015-05-20
No

In the SASUnit batch start script, the shell parameter SASUNIT_COVERAGEASSESSMENT is set to 0.
But the code coverage metrics are computed anyway, see attached screenshot.

If the parameter SASUNIT_COVERAGEASSESSMENT is set to 0, these statistics should not be computed.

2 Attachments

Related

Tickets: #165

Discussion

  • Johannes Lang

    Johannes Lang - 2015-05-20
    • Attachments has changed:

    Diff:

    --- old
    +++ new
    @@ -1 +1,2 @@
     snap_sasunit_v15_config_no_coverageassessment.png (47.6 kB; image/png)
    +snap_sasunit_v15_units_under_test_with_coverageassessment.png (15.4 kB; image/png)
    
     
  • Johannes Lang

    Johannes Lang - 2015-05-21

    Thanks to Klaus Landwich, I know now what the cause was: The parameter must be passed to the %initSASUnit macro, which has a corresponding parameter i_testcoverage.

    But nevertheless, I think there should be an improvement:
    - When the shell parameter SASUNIT_COVERAGEASSESSMENT is defined, but the macro parameter i_testcoverage is not filled, SASUnit should issue a warning that indicates this missing link.
    - And/Or: SASUnit should report the passed value of the macro parameter i_testcoverage on the overview report page.
    - These suggestions also apply for other parameters which are handled this way. The SASUnit user does not automatically know that shell parameters must be manually mapped to %initSASUnit macro parameters in order to work properly.

    Any comments?

     

    Last edit: Johannes Lang 2015-05-21
  • Klaus Landwich

    Klaus Landwich - 2015-05-21

    Yep,

    there you ar definitely right.

    I will issue a warning if a shell parameter differs from the passed parameter.
    Also I will add both values in the over page.

     
  • Klaus Landwich

    Klaus Landwich - 2015-05-21
    • status: open --> assigned
    • assigned_to: Klaus Landwich
     
  • Klaus Landwich

    Klaus Landwich - 2015-05-21
    • Milestone: default --> v2.0
     
  • Klaus Landwich

    Klaus Landwich - 2015-05-31
    • status: assigned --> closed
     
  • Klaus Landwich

    Klaus Landwich - 2015-06-29
    • Milestone: v2.0 --> v1.6
     

Anonymous
Anonymous

Add attachments
Cancel