#1047 Beaming groups erroneous after merging notes

[Heikki Junes]

If you merge in RG Notation beamed notes

e8 e8 e8

into

e4.

the beaming group is not changed. Instead, the beaming group should be always recalculated after a note merge.
Here the beaming group should disappear.

Strange results may appear when you merge for example notes in the middle of a group:

e8 e8 e8 e8

to

e8 e4 e8

In the example above RG notations shows flagged e8 in "e8 e4 e8". If these notes are in the same beaming group, e8 notes should have beams, not flags.

Erroneous beaming groups results in wrong beaming groups in LilyPond output for "e8 e4 e8".

[Heikki Junes]

Logged In: YES
user_id=30776
Originator: YES

This is a bug in the RG Notation Engine: e.g. if "e8 e8 e8" is merged into "e4.", "e4." should not for a beamed group.

This creates LilyPond compile errors for cases like "e4. [ ]".

Committed revision 8022 [be624a], which tries to prevents "e4. [ ]" cases in LilyPond output.

[Heikki Junes]

Added to

https://www.rosegardenmusic.com/wiki/dev:summer_code

(Formerly Bug #1705430)

[Philip Leishman]

OK - another old bug. I looked into this and noticed that doing autoBeam after the collapse sorts things out (at least in most cases). So what if we automatically autoBeam in the collapse...
I have attempted an improvement.
See merge request #87.

[Ted Felix]

I'm not quite clear on the test case here, so I've written up the two mentioned in the original post. Please review and let me know if I'm wrong here. Everything looks good, but I'm not sure I'm testing the right thing and I'm not sure I'm getting the expected results.

Case #1: 8-8-8 -> 4.

• Create a four-bar segment.
• Bring it up in notation.
• Set the time signature to 12/8. Composition > Add Time Signature Change...
• Draw "e4. e8e8e8 e4."
• Confirm e8e8e8 is beamed.
  • PASS
    .
• Select the beamed e8e8e8 group.
• Adjust > Notes > Collapse Equal-Pitch Notes (Ctrl+"=")
• Confirm an "e4."
• Bring up the segment in the Event Editor and examine the "e4.". Segment > Edit With > Open in Event List Editor
• Confirm "beamed" is not present in the first "Type" column.
  • 22.12: FAIL
  • Philip's: PASS
    .
• Perform a print preview.
• Confirm everything looks correct.
  • 22.12: PASS
  • Philip's: PASS
    .

Case #2: 8-8-8-8 -> 8-4-8

• Create a new composition to get back to 4/4 time. File > New.
• Create a four-bar segment.
• Bring it up in notation.
• Draw "e4 e8e8e8e8 e4"
• Confirm e8e8e8e8 is beamed.
  • PASS
    .
• Select the two e8's in the middle.
• Adjust > Notes > Collapse Equal-Pitch Notes (Ctrl+"=")
• Confirm e8e4e8 without beams.
  • 22.12: FAIL. 1/8ths are still beamed over the quarter.
  • Philip's: PASS
    .
• Bring up the segment in the Event Editor and examine the new "e4". Segment > Edit With > Open in Event List Editor
• Confirm "beamed" is not present in the first "Type" column for any of the e8e4e8 notes.
  • 22.12: FAIL. e8e4e8 all have "beamed"
  • Philip's: PASS
    .
• Print Preview
• Confirm e8e4e8 without beams.
  • 22.12: PASS
  • Philip's: PASS

[Philip Leishman]

Yes that is exactly right !
I noticed the problem was easy to fix, when it occurred, by doing autobeam on the damaged notes. So I just added the autobeam to the collapse notes (if it is set on in the settings).

[Ted Felix]

Pushed as [d78deb]. Please test latest git.