RHash / Patches / #3 segsegv due lack of NULL-termination opt.files

#3 segsegv due lack of NULL-termination opt.files

Status: closed-duplicate

Owner: nobody

Labels: None

Priority: 5

Updated: 2011-09-15

Created: 2011-08-19

Creator: Anonymous

Private: No

rhash-1.2.7 dies on sigsegv (depending on previous memory content and malloc implementation) due lack of explicit NULL-termination of opt.files array.
BTW, for whatever reason (it checks only output and not $?) test/test_rhash fails to catch this.

Discussion

Nobody/Anonymous - 2011-08-19

rhash-1.2.7-fix-segv.patch

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Aleksey - 2011-08-20

Thanks for catching, but this bug is duplicate of
#3391587 Segmentation fault running tests
https://sourceforge.net/tracker/?func=detail&aid=3391587&group_id=205103&atid=992288

The attached patch is alternative (but simple) solution to patch from #3391587. Looks like the code is correct, without a buffer overflow.

A agree that $? should be checked, But RHash returns different ExitCodes, not sure if it can be separated from a program crash.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Aleksey - 2011-08-20

status: open --> open-duplicate
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Aleksey - 2011-09-15

the bug was fixed in v1.2.8

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Aleksey - 2011-09-15

status: open-duplicate --> closed-duplicate
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

segsegv due lack of NULL-termination opt.files

Group

Searches

Help

#3 segsegv due lack of NULL-termination opt.files

Discussion