Menu

#63 Monkey-patching object_description is wrong

PyX
closed
nobody
None
1
2015-06-06
2015-06-05
No

Hi,

Revision https://sourceforge.net/p/pyx/code/3651/ changed conf.py to monkey-patch object_description instead of safe_repr.

However, now that code longer makes sense. Unlike safe_repr, object_description strips out memory addresses using its own regex, so trying to match the output against a regex that contains memory address will never succeed. See this diff for details.

Discussion

  • Andre Wobst

    Andre Wobst - 2015-06-06
    • status: open --> closed
     
  • Andre Wobst

    Andre Wobst - 2015-06-06

    thanks for the report, closed by [r3660].

    When I ported the conf.py from Sphinx 1.2 to 1.3 I noticed that safe_repr has advanced to object_description and I just changed our Sphinx patch. It worked immediately. However, I didn't notice that Sphinx 1.3+ now already strips this information itself. Great, we don't need to fiddle in the details of Sphinx anymore!

    Congratulations for this brilliant catch to notice that we still tried to do patch Sphinx even though it's not at all needed anymore. I probably would nave have tried/noticed it myself, but I failed to do so. Thanks a lot!

     

    Related

    Commit: [r3660]


Log in to post a comment.