Menu

#48 Inconsistently exposed variables

1.7.1
open
nobody
5
2012-12-21
2010-06-03
No

I have found a few places where public variables are exposed directly with the m_ notation. It should be exposed with out the m_ prefix using properties or as a method like it's done in many places btVector3().x() ie. IMO these should in general become python properties of the same name minus the 'm_' prefix rather than a method call, btVector3().X on the other hand is a property, I think the ogre3d wrappers and bullet should try to follow the same pattens with regards to this:

RayResultCallback :
['m_closestHitFraction', 'm_collisionFilterGroup', 'm_collisionFilterMask', 'm_collisionObject', 'm_flags']

WheelInfo:
['m_bIsFrontWheel', 'm_brake', 'm_chassisConnectionPointCS', 'm_clientInfo', 'm_clippedInvContactDotSuspension', 'm_deltaRotation', 'm_engineForce', 'm_frictionSlip', 'm_maxSuspensionForce', 'm_maxSuspensionTravelCm', 'm_raycastInfo', 'm_rollInfluence', 'm_rotation', 'm_skidInfo', 'm_steering', 'm_suspensionRelativeVelocity', 'm_suspensionRestLength1', 'm_suspensionStiffness', 'm_wheelAxleCS', 'm_wheelDirectionCS', 'm_wheelsDampingCompression', 'm_wheelsDampingRelaxation', 'm_wheelsRadius', 'm_wheelsSuspensionForce', 'm_worldTransform']

There are probably other cases.

Perhaps the py++ generator script can be updated to spot these cases automatically when generating the wrappers.

Discussion


Log in to post a comment.