Menu

#4 Improve stability for PgVersion

closed-fixed
None
7
2001-09-08
2001-09-08
No

Billy,

I seem to have a talent to provoke segfaults in
innocent software ;-)

import PgSQL
ver = PgSQL.connect().version
print coerce(ver, "")

currently leads to a segfault, because PgVersion_New
expects the input to be in a "reasonable" format. My
patch tries to make the function more tolerant to
garbage input, but it could need a little review,
before I or you commit it.

(In the process of trying to understand what strtok_r
is all about, I also tried to make the code easier to
understand - for me, at least).

Discussion

  • Gerhard Häring

    Gerhard Häring - 2001-09-08
     
  • Billy G. Allie

    Billy G. Allie - 2001-09-08

    Logged In: YES
    user_id=8500

    I've looked at the code and made a few changes. Take a look
    and tell me what you think.

     
  • Billy G. Allie

    Billy G. Allie - 2001-09-08
    • priority: 5 --> 7
    • assigned_to: nobody --> ghaering
     
  • Billy G. Allie

    Billy G. Allie - 2001-09-08
     
  • Gerhard Häring

    Gerhard Häring - 2001-09-08

    Logged In: YES
    user_id=163326

    Thanks for reviewing and improving the patch.

    I've looked at your changes and after some testing, commited it.

    I've also fixed the repr() function of the PgVersion object.

     
  • Gerhard Häring

    Gerhard Häring - 2001-09-08
    • status: open --> closed-fixed
     

Log in to post a comment.