Thread: [PyOpenGL-Devel] [ pyopengl-Patches-805324 ] McMillian Installer and "version" file
Brought to you by:
mcfletch
From: SourceForge.net <no...@so...> - 2003-09-12 20:55:03
|
Patches item #805324, was opened at 2003-09-12 14:55 Message generated for change (Tracker Item Submitted) made by Item Submitter You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305988&aid=805324&group_id=5988 Category: None Group: None Status: Open Resolution: None Priority: 5 Submitted By: Shane Holloway (shane_holloway) Assigned to: Nobody/Anonymous (nobody) Summary: McMillian Installer and "version" file Initial Comment: After fiddling with the McMillian Installer (http://www.mcmillan-inc.com/install5_intro.html) and my little PyOpenGL client application, I found what was causing the OpenGL import to fail -- the reading of the "version" file in the root of the package. If you are not familar with the McMillian Installer, it effecitvely zips up all modules and packages your application is dependent upon, and packs that information to the tail end of an executable file. It does this by detecting all imports and also has a mechanism for adding modules manually. However, it does not have a mechanism for detecting or including standard files in the fashion that OpenGL/__init__.py file is using. So therefore, it has trouble importing OpenGL in the McMillian Installer, and thus my patch. :) There are a few ways in which we can accomplish fixing this problem. 1. We could hard code the version number in the __init__.py (yuck! -- that's why there is a "version" file in the first place) 2. We can do a try/except block around the reading of the file. (what value does OpenGL.__version__ get when this error occurs? If we set it to some default value, this potentially changes the behavior of any version dependent code in the application. This is undersierable... I like things to work the same in or out of the packaging. 3. We can rename "version" to "__version__.py", change the syntax slightly, and change the "__init__.py" file to deal with those new changes. (This allows packaging implementations like Installer and cx_Freeze detect the import and include it in the packaging.) I like the 3rd option the best, and thereby have created a patch to implement that feature. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305988&aid=805324&group_id=5988 |
From: SourceForge.net <no...@so...> - 2003-09-12 20:58:05
|
Patches item #805324, was opened at 2003-09-12 14:55 Message generated for change (Comment added) made by shane_holloway You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305988&aid=805324&group_id=5988 Category: None Group: None Status: Open Resolution: None Priority: 5 Submitted By: Shane Holloway (shane_holloway) >Assigned to: Tarn Weisner Burton (twburton) Summary: McMillian Installer and "version" file Initial Comment: After fiddling with the McMillian Installer (http://www.mcmillan-inc.com/install5_intro.html) and my little PyOpenGL client application, I found what was causing the OpenGL import to fail -- the reading of the "version" file in the root of the package. If you are not familar with the McMillian Installer, it effecitvely zips up all modules and packages your application is dependent upon, and packs that information to the tail end of an executable file. It does this by detecting all imports and also has a mechanism for adding modules manually. However, it does not have a mechanism for detecting or including standard files in the fashion that OpenGL/__init__.py file is using. So therefore, it has trouble importing OpenGL in the McMillian Installer, and thus my patch. :) There are a few ways in which we can accomplish fixing this problem. 1. We could hard code the version number in the __init__.py (yuck! -- that's why there is a "version" file in the first place) 2. We can do a try/except block around the reading of the file. (what value does OpenGL.__version__ get when this error occurs? If we set it to some default value, this potentially changes the behavior of any version dependent code in the application. This is undersierable... I like things to work the same in or out of the packaging. 3. We can rename "version" to "__version__.py", change the syntax slightly, and change the "__init__.py" file to deal with those new changes. (This allows packaging implementations like Installer and cx_Freeze detect the import and include it in the packaging.) I like the 3rd option the best, and thereby have created a patch to implement that feature. ---------------------------------------------------------------------- >Comment By: Shane Holloway (shane_holloway) Date: 2003-09-12 14:58 Message: Logged In: YES user_id=283742 Sorry, I could not figure out how to get the file to be in the patch without adding it to cvs first... What's the magic phrase? Anyhow, this file should complement the patch by going into PyOpenGL2/OpenGL/__version__.py ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=305988&aid=805324&group_id=5988 |