Menu

#161 residual clang warning

v1.6.2.0
closed-accepted
None
5
2015-03-16
2015-03-14
No

One last non-C++11 extension warning remains in current pymol svn...

layer2/RepCylBond.cpp:1416:38: warning: '&&' within '||' [-Wlogical-op-parentheses]
(cartoon_side_chain_helper && (ati1->visRep & ati2->visRep & cRepCartoonBit) ||
~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ~~
layer2/RepCylBond.cpp:1416:38: note: place parentheses around the '&&' expression to silence this warning
(cartoon_side_chain_helper && (ati1->visRep & ati2->visRep & cRepCartoonBit) ||
^
( )
layer2/RepCylBond.cpp:1417:37: warning: '&&' within '||' [-Wlogical-op-parentheses]
ribbon_side_chain_helper && (ati1->visRep & ati2->visRep & cRepRibbonBit))) {
~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
layer2/RepCylBond.cpp:1417:37: note: place parentheses around the '&&' expression to silence this warning
ribbon_side_chain_helper && (ati1->visRep & ati2->visRep & cRepRibbonBit))) {
^
( )

The attach patch implements this recommended change in layer2/RepCylBond.cpp.

1 Attachments

Discussion

  • Thomas Holder

    Thomas Holder - 2015-03-16
    • status: open --> closed-accepted
    • assigned_to: Thomas Holder
     
  • Thomas Holder

    Thomas Holder - 2015-03-16

    applied to SVN rev 4111

     

Log in to post a comment.