UpnpSetVirtualDirCallbacks API removal in 1.6.x

Brought to you by: mroberto, npapadop

#29 UpnpSetVirtualDirCallbacks API removal in 1.6.x

Milestone: branch-1.6.x

Status: closed-accepted

Owner: Nick Leverton

Labels: upnp (66)

Priority: 5

Updated: 2012-03-16

Created: 2010-04-19

Creator: Nick Leverton

Private: No

The recent codebase merge has removed a significant API call which is used by several pupnp devices such as mediatomb and gmediaserver. UpnpSetVirtualDirCallbacks() has been replaced by individual routines to set each callback. Essentially this means that 1.6.7 will in fact be a major bump and 1.6.6 devices can no longer link against it. Could we have the call reinstated please, perhaps as a wrapper around the individual calls ? As it is, all distros will have to patch their 1.6.x apps, rebuild and re-link them.

The other removed API calls and external variables don't seem to be used by any of the apps I have copies of, but UpnpSetVirtualDirCallbacks is important for maintaining compatibility within 1.6.x

Discussion

Jin - 2010-04-19

FYI: MediaTomb is not directly using pupnp, so we're not affected by any pupnp API changes.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Nick Leverton - 2010-04-19

Thanks jin_eld, I'd originally assumed tombupnp was a straight copy of intel upnp, which a couple of other packages also include. Whilst reading up on the copyright history this evening I now understand that it's not.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Marcelo Roberto Jimenez - 2010-09-30

Hi Nick, is it possible for you to build a patch for this issue?

Regards,
Marcelo.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Marcelo Roberto Jimenez - 2010-10-02

status: open --> closed
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Marcelo Roberto Jimenez - 2010-10-02

Well, for now I will assume this is no longer an issue. If someone has a problem, please reopen.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Marcelo Roberto Jimenez - 2011-10-21

Reopened as per Nick's request.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Marcelo Roberto Jimenez - 2011-10-21

Reopened as per Nick's request.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Marcelo Roberto Jimenez - 2011-10-21

status: closed --> open
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Nick Leverton - 2011-11-30

Suggested patch for review

17-debian-virtualcallbacks.patch

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Nick Leverton - 2011-11-30

Hi Marcelo,

Sorry for slow progress on this. Would you mind reviewing the attached patch to reinstate UpnpSetVirtualDirCallbacks(), please ?

Nick

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Marcelo Roberto Jimenez - 2012-03-05

assigned_to: nobody --> leveret

status: open --> open-accepted
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Marcelo Roberto Jimenez - 2012-03-05

Hi Nick,

I will commit the patch, but I assume this is work in progress, right?

There seems to be no problem in keeping this code, but it seems to be doing nothing for now. At least it restores the API.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Marcelo Roberto Jimenez - 2012-03-14

milestone: --> branch-1.6.x
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Nick Leverton - 2012-03-15

Thanks for reinstating this, Marcelo. I'm open to improvements if you wish but this simple call worksforme, I'd be happy to close the issue.

You're right that it doens't do anything the individual calls don't, it is just to keep the API the same to save increasing the SONAME (as that causes a library transition and therefore the need to rebuild all dependent packages in every distro).
Of course since I raised this issue, the SONAME has been incremented anyway, but I think it will help users to keep the user interface as much the same as possible.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Marcelo Roberto Jimenez - 2012-03-16

status: open-accepted --> closed-accepted
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Marcelo Roberto Jimenez - 2012-03-16

Well, let's close it then. If someone wants to take it from there, the door is open.

Regards,
Marcelo.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link: