prboom-plus / Bugs / #230 menu items not highlighted in chex/hacx mode

#230 menu items not highlighted in chex/hacx mode

Milestone: v2.2.6.*

Status: closed-fixed

Owner: nobody

Labels: None

Priority: 5

Updated: 2017-05-10

Created: 2013-07-01

Creator: Fabian Greffrath

Private: No

When playing Chex Quest or HACX the menu items in the Options->General menu and the submenus beneath Options->Setup are not highlighted. The default text color in Chex Quest and HACX is green and blue, respectively. I believe the text does not get highlighted, because the color translation tables do only apply to the red color channel, but I have not yet found the right code to change this.

Discussion

Fabian Greffrath - 2013-07-04

The attached patch applies the palette translations to the green and blue range as well if the current gamemode is detected as chex or hacx, respectively.

prbp-chex-hacx-palette.patch

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Fabian Greffrath - 2013-08-05

Is it too risky to change the palette this way or are there any other objections against this patch?

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Andrey Budko - 2013-08-06

I don't know how does it work, but probably it's not a good idea to hack palette. Probably we need to add some marker to mark current menu? Something like Eternity does

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Fabian Greffrath - 2013-08-06

The patch does not modify the entire palette, just the CR_* lumps that map shades of red to other color. The patch applies this to the green and blue color ranges as well.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Fabian Greffrath - 2017-05-08

I'd like to ask for this patch to get revisited.

Currently, the color translation tables CR_x map the red colors in the palette to some other colors to achieve the desired color translation effect. However, they only apply to the red ranges and do not touch colors that are originally e.g. green or blue. This is bad, because Chex Quest's and Hacx's respective menus are entirely composed of green and blue text graphics.

What this patch does is applying the color translations from the translation tables (that so far only applied to red colors) also to the green range (starting at palette offset 112) and the blue range (starting at palette offset 192) of the palette. As a result, there are now also red, golden and green entries in Hacx's menu, where there were only blue letters before. Same for Chex Quest which had only plain green letters before.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Andrey Budko - 2017-05-10

status: open --> closed-fixed
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Fabian Greffrath - 2017-05-10

Thanks for applying!

NB: This should also fix colored health etc. indicators in the status bar.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Log in to post a comment.